Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1954983002: [turbofan] Remove obsolete EffectSet common operator. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove obsolete EffectSet common operator. This operator was initially designed to handle arbitrary effect merging for effect relaxation, but we don't do that (at least currently). So no need to keep the dead operator around. R=jarin@chromium.org Committed: https://crrev.com/8e5e6333cf58013e54a6a52c900b6dda01045de7 Cr-Commit-Position: refs/heads/master@{#36063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M src/compiler/common-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-06 05:43:15 UTC) #1
Benedikt Meurer
Hey Jaro, As usual, dead code must be dead. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-06 05:43:55 UTC) #2
Igor Sheludko
lgtm
4 years, 7 months ago (2016-05-06 07:41:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954983002/1
4 years, 7 months ago (2016-05-06 07:42:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-06 07:44:36 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 07:46:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e5e6333cf58013e54a6a52c900b6dda01045de7
Cr-Commit-Position: refs/heads/master@{#36063}

Powered by Google App Engine
This is Rietveld 408576698