Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/compiler/verifier.cc

Issue 1954983002: [turbofan] Remove obsolete EffectSet common operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 } 410 }
411 case IrOpcode::kEffectPhi: { 411 case IrOpcode::kEffectPhi: {
412 // EffectPhi input count matches parent control node. 412 // EffectPhi input count matches parent control node.
413 CHECK_EQ(0, value_count); 413 CHECK_EQ(0, value_count);
414 CHECK_EQ(1, control_count); 414 CHECK_EQ(1, control_count);
415 Node* control = NodeProperties::GetControlInput(node, 0); 415 Node* control = NodeProperties::GetControlInput(node, 0);
416 CHECK_EQ(effect_count, control->op()->ControlInputCount()); 416 CHECK_EQ(effect_count, control->op()->ControlInputCount());
417 CHECK_EQ(input_count, 1 + effect_count); 417 CHECK_EQ(input_count, 1 + effect_count);
418 break; 418 break;
419 } 419 }
420 case IrOpcode::kEffectSet: {
421 CHECK_EQ(0, value_count);
422 CHECK_EQ(0, control_count);
423 CHECK_LT(1, effect_count);
424 break;
425 }
426 case IrOpcode::kGuard: 420 case IrOpcode::kGuard:
427 // TODO(bmeurer): what are the constraints on these? 421 // TODO(bmeurer): what are the constraints on these?
428 break; 422 break;
429 case IrOpcode::kBeginRegion: 423 case IrOpcode::kBeginRegion:
430 // TODO(rossberg): what are the constraints on these? 424 // TODO(rossberg): what are the constraints on these?
431 break; 425 break;
432 case IrOpcode::kFinishRegion: { 426 case IrOpcode::kFinishRegion: {
433 // TODO(rossberg): what are the constraints on these? 427 // TODO(rossberg): what are the constraints on these?
434 // Type must be subsumed by input type. 428 // Type must be subsumed by input type.
435 if (typing == TYPED) { 429 if (typing == TYPED) {
(...skipping 924 matching lines...) Expand 10 before | Expand all | Expand 10 after
1360 replacement->op()->EffectOutputCount() > 0); 1354 replacement->op()->EffectOutputCount() > 0);
1361 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1355 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1362 replacement->opcode() == IrOpcode::kFrameState); 1356 replacement->opcode() == IrOpcode::kFrameState);
1363 } 1357 }
1364 1358
1365 #endif // DEBUG 1359 #endif // DEBUG
1366 1360
1367 } // namespace compiler 1361 } // namespace compiler
1368 } // namespace internal 1362 } // namespace internal
1369 } // namespace v8 1363 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/node-test-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698