Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1954943003: Fix checkdeps when includes contain "../" in them. (Closed)

Created:
4 years, 7 months ago by smaier
Modified:
4 years, 7 months ago
Reviewers:
brettw
Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Fix checkdeps when includes contain "../" in them. This comes up for third_party files. BUG=332521 R=brettw@chromium.org Committed: 3107494cfff626aae1d6f6a6fc953ffa53d3b227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M checkdeps/checkdeps.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
smaier
This change is required for: https://codereview.chromium.org/1951363002/
4 years, 7 months ago (2016-05-06 17:05:16 UTC) #2
brettw
LGTM
4 years, 7 months ago (2016-05-06 17:26:41 UTC) #3
agrieve
4 years, 7 months ago (2016-05-06 18:21:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3107494cfff626aae1d6f6a6fc953ffa53d3b227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698