checkdeps/checkdeps.py - Issue 1954943003: Fix checkdeps when includes contain "../" in them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: checkdeps/checkdeps.py

Issue 1954943003: Fix checkdeps when includes contain "../" in them. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: checkdeps/checkdeps.py

diff --git a/checkdeps/checkdeps.py b/checkdeps/checkdeps.py

index 85e0ae998f94b66b2c43198147b5be4322678bd3..d61643d708b87fed60f2cb9357722b60da0ef4e6 100755

--- a/checkdeps/checkdeps.py

+++ b/checkdeps/checkdeps.py

@@ -107,7 +107,7 @@ class DepsChecker(DepsBuilder):

where rule_type is one of Rule.DISALLOW or Rule.TEMP_ALLOW and

rule_description is human-readable. Empty if no problems.

"""

- cpp = cpp_checker.CppChecker(self.verbose)

+ cpp = cpp_checker.CppChecker(self.verbose, self._resolve_dotdot)

problems = []

for file_path, include_lines in added_includes:

if not cpp.IsCppFile(file_path):

« no previous file with comments | « no previous file | no next file » | no next file with comments »