Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1954683002: Revert of [css-grid] Fix definite/indefinite size detection for abspos elements (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [css-grid] Fix definite/indefinite size detection for abspos elements (patchset #2 id:20001 of https://codereview.chromium.org/1383003002/ ) Reason for revert: This is breaking how percentages work in Flexbox and Grid compared to regular Blocks. There're some discussion ongoing on the CSS WG to verify the expected behavior, so we're reverting this for now until we've a final resolution. Original issue's description: > [css-grid] Fix definite/indefinite size detection for abspos elements > > We were considering that any abspos element has a definite size, and > that's not true. That's only true if the offset properties in that > dimension (left and right or top and bottom) are non-auto. > Fixed LayoutBox::hasDefiniteLogicalWidth|Height() to check this > properly. > > This has been confirmed by the CSS WG in the following thread: > https://lists.w3.org/Archives/Public/www-style/2015Nov/0074.html > > BUG=538513 > TEST=fast/css-grid-layout/positioned-grid-container-percentage-tracks.html > > Committed: https://crrev.com/b75b9bdaa3ede6fe0230ae822885d6fb38ed514b > Cr-Commit-Position: refs/heads/master@{#386045} TBR=cbiesinger@chromium.org,svillar@igalia.com,mstensho@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=538513, 603854, 604346, 608783 Committed: https://crrev.com/83e80002d146d1493ae16c1cb585cc458e955ee3 Cr-Commit-Position: refs/heads/master@{#391789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -107 lines) Patch
D third_party/WebKit/LayoutTests/fast/css-grid-layout/positioned-grid-container-percentage-tracks.html View 1 chunk +0 lines, -103 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Manuel Rego
Created Revert of [css-grid] Fix definite/indefinite size detection for abspos elements
4 years, 7 months ago (2016-05-05 10:03:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954683002/1
4 years, 7 months ago (2016-05-05 10:04:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 12:18:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 12:19:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83e80002d146d1493ae16c1cb585cc458e955ee3
Cr-Commit-Position: refs/heads/master@{#391789}

Powered by Google App Engine
This is Rietveld 408576698