CFX_ArabicChar contains only static methods, no need to instantiate.

CFX_ArabicChar contains only static methods, no need to instantiate.

Committed: https://pdfium.googlesource.com/pdfium/+/e00f75c2318d55dfa261f1915decd2545c44ccfb

[Tom Sepez, 2016-05-06 17:56:38]

Description was changed from

==========
fx_arabic contains only static methods, no need to instantiate.
==========

to

==========
fx_arabic contains only static methods, no need to instantiate.

Fix some misc. const/bool along the way.
==========

[Tom Sepez, 2016-05-06 17:58:04]

Description was changed from

==========
fx_arabic contains only static methods, no need to instantiate.

Fix some misc. const/bool along the way.
==========

to

==========
fx_arabic contains only static methods, no need to instantiate.
==========

[Tom Sepez, 2016-05-06 17:58:04]

tsepez@chromium.org changed reviewers:
+ weili@google.com

[Tom Sepez, 2016-05-06 17:58:33]

Wei, pls review (Dan/Lei OOO).

[Tom Sepez, 2016-05-06 18:01:18]

Description was changed from

==========
fx_arabic contains only static methods, no need to instantiate.
==========

to

==========
CFX_ArabicChar contains only static methods, no need to instantiate.
==========

[Wei Li, 2016-05-06 18:58:27]

weili@chromium.org changed reviewers:
+ weili@chromium.org

[Wei Li, 2016-05-06 18:58:28]

https://codereview.chromium.org/1954593004/diff/40001/core/fxcrt/include/fx_a...
File core/fxcrt/include/fx_arabic.h (right):

https://codereview.chromium.org/1954593004/diff/40001/core/fxcrt/include/fx_a...
core/fxcrt/include/fx_arabic.h:30: CFX_ArabicChar() = delete;  // Just a
namespace !!!
Looks like namespace is preferred in this case
https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_a...

[Tom Sepez, 2016-05-06 19:07:11]

Done.

[Tom Sepez, 2016-05-06 19:17:18]

On 2016/05/06 19:07:11, Tom Sepez wrote:
> Done.

Ok, PTAL.

[Wei Li, 2016-05-06 19:50:20]

On 2016/05/06 19:17:18, Tom Sepez wrote:
> On 2016/05/06 19:07:11, Tom Sepez wrote:
> > Done.
> 
> Ok, PTAL.

lgtm

[Tom Sepez, 2016-05-06 19:59:21]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-05-06 19:59:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954593004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954593004/100001

[commit-bot: I haz the power, 2016-05-06 20:15:51]

Description was changed from

==========
CFX_ArabicChar contains only static methods, no need to instantiate.
==========

to

==========
CFX_ArabicChar contains only static methods, no need to instantiate.

Committed:
https://pdfium.googlesource.com/pdfium/+/e00f75c2318d55dfa261f1915decd2545c44...
==========

[commit-bot: I haz the power, 2016-05-06 20:15:51]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/e00f75c2318d55dfa261f1915decd2545c44...