CFX_ArabicChar contains only static methods, no need to instantiate.

xfa/fgas/layout/fgas_textbreak.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fgas/layout/fgas_textbreak.h"
 
 #include <algorithm>
 
 #include "core/fxcrt/include/fx_arabic.h"
 #include "core/fxcrt/include/fx_arb.h"
 #include "core/fxcrt/include/fx_memory.h"
 #include "xfa/fgas/layout/fgas_linebreak.h"
 #include "xfa/fgas/layout/fgas_unicode.h"
 
 CFX_TxtBreak::CFX_TxtBreak(uint32_t dwPolicies)
     : m_dwPolicies(dwPolicies),
-      m_pArabicChar(NULL),
       m_iLineWidth(2000000),
       m_dwLayoutStyles(0),
       m_bVertical(FALSE),
       m_bArabicContext(FALSE),
       m_bArabicShapes(FALSE),
       m_bRTL(FALSE),
       m_bSingleLine(FALSE),
       m_bCombText(FALSE),
       m_iArabicContext(1),
       m_iCurArabicContext(1),
@@ skipping 14 matching lines @@
       m_dwCharType(0),
       m_bArabicNumber(FALSE),
       m_bArabicComma(FALSE),
       m_pCurLine(NULL),
       m_iReady(0),
       m_iTolerance(0),
       m_iHorScale(100),
       m_iVerScale(100),
       m_iCharSpace(0) {
   m_bPagination = (m_dwPolicies & FX_TXTBREAKPOLICY_Pagination) != 0;
-  m_pArabicChar = new CFX_ArabicChar;
   if (m_bPagination) {
     m_pTxtLine1 = new CFX_TxtLine(sizeof(CFX_Char));
     m_pTxtLine2 = new CFX_TxtLine(sizeof(CFX_Char));
   } else {
     m_pTxtLine1 = new CFX_TxtLine(sizeof(CFX_TxtChar));
     m_pTxtLine2 = new CFX_TxtLine(sizeof(CFX_TxtChar));
   }
   m_pCurLine = m_pTxtLine1;
   ResetArabicContext();
 }
 CFX_TxtBreak::~CFX_TxtBreak() {
   Reset();
   delete m_pTxtLine1;
   delete m_pTxtLine2;
-  m_pArabicChar->Release();
 }
 void CFX_TxtBreak::SetLineWidth(FX_FLOAT fLineWidth) {
   m_iLineWidth = FXSYS_round(fLineWidth * 20000.0f);
   ASSERT(m_iLineWidth >= 20000);
 }
 void CFX_TxtBreak::SetLinePos(FX_FLOAT fLinePos) {
   int32_t iLinePos = FXSYS_round(fLinePos * 20000.0f);
   if (iLinePos < 0) {
     iLinePos = 0;
   }
@@ skipping 378 matching lines @@
   FX_BOOL bAlef = FALSE;
   if (!m_bCombText && m_dwCharType >= FX_CHARTYPE_ArabicAlef &&
       m_dwCharType <= FX_CHARTYPE_ArabicDistortion) {
     pLastChar = GetLastChar(1);
     if (pLastChar != NULL) {
       iCharWidth = pLastChar->m_iCharWidth;
       if (iCharWidth > 0) {
         iLineWidth -= iCharWidth;
       }
       CFX_Char* pPrevChar = GetLastChar(2);
-      wForm = m_pArabicChar->GetFormChar(pLastChar, pPrevChar, pCurChar);
+      wForm = pdfium::arabic::GetFormChar(pLastChar, pPrevChar, pCurChar);
       bAlef = (wForm == 0xFEFF &&
                pLastChar->GetCharType() == FX_CHARTYPE_ArabicAlef);
       int32_t iLastRotation = pLastChar->m_nRotation + m_iLineRotation;
       if (m_bVertical && (pLastChar->m_dwCharProps & 0x8000) != 0) {
         iLastRotation++;
       }
       if (m_bVertical != FX_IsOdd(iLastRotation)) {
         iCharWidth = 1000;
       } else {
         m_pFont->GetCharWidth(wForm, iCharWidth, FALSE);
       }
       if (wForm == 0xFEFF) {
         iCharWidth = m_iDefChar;
       }
       iCharWidth *= m_iFontSize;
       iCharWidth = iCharWidth * m_iHorScale / 100;
       pLastChar->m_iCharWidth = iCharWidth;
       iLineWidth += iCharWidth;
       iCharWidth = 0;
     }
   }
   m_dwCharType = dwType;
-  wForm = m_pArabicChar->GetFormChar(pCurChar, bAlef ? NULL : pLastChar, NULL);
+  wForm = pdfium::arabic::GetFormChar(pCurChar, bAlef ? NULL : pLastChar, NULL);
   if (m_bCombText) {
     iCharWidth = m_iCombWidth;
   } else {
     if (m_bVertical != FX_IsOdd(iRotation)) {
       iCharWidth = 1000;
     } else {
       m_pFont->GetCharWidth(wForm, iCharWidth, FALSE);
     }
     if (wForm == 0xFEFF) {
       iCharWidth = m_iDefChar;
@@ skipping 759 matching lines @@
             wNext = pStr[j];
             dwProps = FX_GetUnicodeProperties(wNext);
           } while ((dwProps & FX_CHARTYPEBITSMASK) == FX_CHARTYPE_Combination);
           if (i + j >= iLength) {
             wNext = 0xFEFF;
           }
         }
       } else {
         wNext = 0xFEFF;
       }
-      wForm = m_pArabicChar->GetFormChar(wch, wPrev, wNext);
+      wForm = pdfium::arabic::GetFormChar(wch, wPrev, wNext);
       bLam = (wPrev == 0x0644 && wch == 0x0644 && wNext == 0x0647);
     } else if (dwCharType == FX_CHARTYPE_Combination) {
       wForm = wch;
       if (wch >= 0x064C && wch <= 0x0651) {
         if (bShadda) {
           wForm = 0xFEFF;
           bShadda = FALSE;
         } else {
           wNext = 0xFEFF;
           if (pAccess != NULL) {
@@ skipping 368 matching lines @@
         rtBBoxF.height = fHeight;
         rtBBoxF.top = std::max(rtBBoxF.top, 0.0f);
       }
       rtArray.SetAt(i, rtBBoxF);
       continue;
     }
     rtArray.SetAt(i, rect);
   }
   return iLength;
 }