Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1954573002: Disable screenshots on VMs. (Closed)

Created:
4 years, 7 months ago by achuithb
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Disable screenshots on VMs. GetFileContents works locally. /sys/class/dmi/id/sys_vendor has vendor information, and this is 'QEMU' for VMs. BUG=chromium:609001 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4637f1a9a4a9b7ad7bd565a4dd9fcc1310da30ee

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M telemetry/telemetry/core/cros_interface.py View 2 chunks +12 lines, -9 lines 0 comments Download
M telemetry/telemetry/internal/platform/cros_platform_backend.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954573002/1
4 years, 7 months ago (2016-05-04 21:51:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954573002/20001
4 years, 7 months ago (2016-05-04 21:53:58 UTC) #4
achuithb
Ned, could you please take a look?
4 years, 7 months ago (2016-05-04 21:54:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 22:24:12 UTC) #9
nednguyen
lgtm
4 years, 7 months ago (2016-05-04 22:31:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954573002/20001
4 years, 7 months ago (2016-05-04 22:31:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4637f1a9a4a9b7ad7bd565a4dd9fcc1310da30ee
4 years, 7 months ago (2016-05-04 22:32:54 UTC) #14
achuithb
4 years, 7 months ago (2016-05-04 22:33:53 UTC) #15
Message was sent while issue was closed. 
On 2016/05/04 22:31:16, nednguyen wrote:
> lgtm

ty

Powered by Google App Engine
This is Rietveld 408576698