telemetry/telemetry/internal/platform/cros_platform_backend.py - Issue 1954573002: Disable screenshots on VMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/cros_platform_backend.py

Issue 1954573002: Disable screenshots on VMs. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/platform/cros_platform_backend.py

diff --git a/telemetry/telemetry/internal/platform/cros_platform_backend.py b/telemetry/telemetry/internal/platform/cros_platform_backend.py

index bc87ab4c26ccaa6f0990aaddeeb21ba0f13360c0..1cc76d65ade525fda47bfcd400940c9a6b878699 100644

--- a/telemetry/telemetry/internal/platform/cros_platform_backend.py

+++ b/telemetry/telemetry/internal/platform/cros_platform_backend.py

@@ -169,7 +169,8 @@ class CrosPlatformBackend(

return self._cri.FileExistsOnDevice(path)

def CanTakeScreenshot(self):

- return True

+ # crbug.com/609001: screenshots don't work on VMs.

+ return not self.cri.IsRunningOnVM()

def TakeScreenshot(self, file_path):

return self._cri.TakeScreenshot(file_path)

« no previous file with comments | « telemetry/telemetry/core/cros_interface.py ('k') | no next file » | no next file with comments »