Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1954563002:
Fix horizontal virtual keyboard icon missing black background and misaligned after login (Closed)
|
Created:
4 years, 7 months ago by Qiang(Joe) Xu Modified:
4 years, 7 months ago Reviewers:
stevenjb CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix horizontal virtual keyboard icon missing black background and misaligned after login
Bug is appearing after login when shelf is set to horizontal alignment. It can be corrected on SetShelfAlignment call.
BUG=604621
Committed: https://crrev.com/dd380301037a13b0247ee21209fba2413ce15a08
Cr-Commit-Position: refs/heads/master@{#391915}
Patch Set 1 #
Total comments: 3
Patch Set 2 : using system_tray_ instead #Patch Set 3 : #Messages
Total messages: 20 (9 generated)
The CQ bit was checked by warx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954563002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login BUG= ========== to ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It will be missing every time SetShelfAlignment is called. BUG=604621 ==========
warx@chromium.org changed reviewers: + stevenjb@chromium.org
Description was changed from ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It will be missing every time SetShelfAlignment is called. BUG=604621 ========== to ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It can be corrected on SetShelfAlignment call. BUG=604621 ==========
https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... File ash/system/status_area_widget.cc (right): https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... ash/system/status_area_widget.cc:78: virtual_keyboard_tray_->shelf_alignment()); Should we call SetShelfAlignment(system_tray_->shelf_alignment()) instead to ensure that all tray items are aligned correctly?
https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... File ash/system/status_area_widget.cc (right): https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... ash/system/status_area_widget.cc:78: virtual_keyboard_tray_->shelf_alignment()); On 2016/05/04 22:57:33, stevenjb wrote: > Should we call SetShelfAlignment(system_tray_->shelf_alignment()) instead to > ensure that all tray items are aligned correctly? agree, that is better.
https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... File ash/system/status_area_widget.cc (right): https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... ash/system/status_area_widget.cc:78: virtual_keyboard_tray_->shelf_alignment()); On 2016/05/04 23:26:45, Qiang (Joe) Xu wrote: > On 2016/05/04 22:57:33, stevenjb wrote: > > Should we call SetShelfAlignment(system_tray_->shelf_alignment()) instead to > > ensure that all tray items are aligned correctly? > > agree, that is better. Sorry, I wasn't clear. I was suggesting: SetShelfAlignment(system_tray_->shelf_alignment()) Which would call SetShelfAlignment for virtual_keyboard_tray_ and all other elements. This should be outside of the #if CHROMEOS (after all Initialize() calls). That does do an extra call to UpdateLayout(), but I think that should be fine.
Patchset #3 (id:40001) has been deleted
On 2016/05/05 16:20:50, stevenjb wrote: > https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... > File ash/system/status_area_widget.cc (right): > > https://codereview.chromium.org/1954563002/diff/1/ash/system/status_area_widg... > ash/system/status_area_widget.cc:78: virtual_keyboard_tray_->shelf_alignment()); > On 2016/05/04 23:26:45, Qiang (Joe) Xu wrote: > > On 2016/05/04 22:57:33, stevenjb wrote: > > > Should we call SetShelfAlignment(system_tray_->shelf_alignment()) instead to > > > ensure that all tray items are aligned correctly? > > > > agree, that is better. > > Sorry, I wasn't clear. I was suggesting: > > SetShelfAlignment(system_tray_->shelf_alignment()) > > Which would call SetShelfAlignment for virtual_keyboard_tray_ and all other > elements. This should be outside of the #if CHROMEOS (after all Initialize() > calls). > > That does do an extra call to UpdateLayout(), but I think that should be fine. done. Change becomes an initial SetShelfAlignment call for all. It will do the work. Thanks!
lgtm
The CQ bit was checked by warx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954563002/60001
Message was sent while issue was closed.
Description was changed from ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It can be corrected on SetShelfAlignment call. BUG=604621 ========== to ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It can be corrected on SetShelfAlignment call. BUG=604621 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It can be corrected on SetShelfAlignment call. BUG=604621 ========== to ========== Fix horizontal virtual keyboard icon missing black background and misaligned after login Bug is appearing after login when shelf is set to horizontal alignment. It can be corrected on SetShelfAlignment call. BUG=604621 Committed: https://crrev.com/dd380301037a13b0247ee21209fba2413ce15a08 Cr-Commit-Position: refs/heads/master@{#391915} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/dd380301037a13b0247ee21209fba2413ce15a08 Cr-Commit-Position: refs/heads/master@{#391915} |
