Fix horizontal virtual keyboard icon missing black background and misaligned after login

ash/system/status_area_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/status_area_widget.h"
 
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_widget.h"
 #include "ash/shell.h"
@@ skipping 55 matching lines @@
 
   SystemTrayDelegate* delegate =
       ash::Shell::GetInstance()->system_tray_delegate();
   DCHECK(delegate);
   // Initialize after all trays have been created.
   system_tray_->InitializeTrayItems(delegate);
   web_notification_tray_->Initialize();
 #if defined(OS_CHROMEOS)
   logout_button_tray_->Initialize();
   virtual_keyboard_tray_->Initialize();
+  // Initial virtual keyboard alignment for crbug.com/604621.
+  virtual_keyboard_tray_->SetShelfAlignment(
+      virtual_keyboard_tray_->shelf_alignment());

[stevenjb, 2016/05/04 22:57:33]

Should we call SetShelfAlignment(system_tray_->shelf_alignment()) instead to
ensure that all tray items are aligned correctly?

[Qiang(Joe) Xu, 2016/05/04 23:26:45]

agree, that is better.

[stevenjb, 2016/05/05 16:20:49]

Sorry, I wasn't clear. I was suggesting:

  SetShelfAlignment(system_tray_->shelf_alignment())

Which would call SetShelfAlignment for virtual_keyboard_tray_ and all other
elements. This should be outside of the #if CHROMEOS (after all Initialize()
calls).

That does do an extra call to UpdateLayout(), but I think that should be fine.

 #endif
   overview_button_tray_->Initialize();
   UpdateAfterLoginStatusChange(delegate->GetUserLoginStatus());
 }
 
 void StatusAreaWidget::Shutdown() {
   // Destroy the trays early, causing them to be removed from the view
   // hierarchy. Do not used scoped pointers since we don't want to destroy them
   // in the destructor if Shutdown() is not called (e.g. in tests).
   delete web_notification_tray_;
@@ skipping 109 matching lines @@
     web_notification_tray_->UpdateAfterLoginStatusChange(login_status);
 #if defined(OS_CHROMEOS)
   if (logout_button_tray_)
     logout_button_tray_->UpdateAfterLoginStatusChange(login_status);
 #endif
   if (overview_button_tray_)
     overview_button_tray_->UpdateAfterLoginStatusChange(login_status);
 }
 
 }  // namespace ash