Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: media/blink/multibuffer_unittest.cc

Issue 1954493002: Tweak multibuffer buffering strategy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/multibuffer_reader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_unittest.cc
diff --git a/media/blink/multibuffer_unittest.cc b/media/blink/multibuffer_unittest.cc
index f0f28f1c0680815ebacec7fd3088c232e03fbaa4..27198ec8ab3b0ccb63e084f42facf9ac03de170b 100644
--- a/media/blink/multibuffer_unittest.cc
+++ b/media/blink/multibuffer_unittest.cc
@@ -266,7 +266,7 @@ TEST_F(MultiBufferTest, ReadAll) {
multibuffer_.SetMustReadWholeFile(true);
MultiBufferReader reader(&multibuffer_, pos, end,
base::Callback<void(int64_t, int64_t)>());
- reader.SetMaxBuffer(2000, 5000);
+ reader.SetPinRange(2000, 5000);
reader.SetPreload(1000, 1000);
while (pos < end) {
unsigned char buffer[27];
@@ -294,7 +294,7 @@ TEST_F(MultiBufferTest, ReadAllAdvanceFirst) {
multibuffer_.SetMustReadWholeFile(true);
MultiBufferReader reader(&multibuffer_, pos, end,
base::Callback<void(int64_t, int64_t)>());
- reader.SetMaxBuffer(2000, 5000);
+ reader.SetPinRange(2000, 5000);
reader.SetPreload(1000, 1000);
while (pos < end) {
unsigned char buffer[27];
@@ -324,7 +324,7 @@ TEST_F(MultiBufferTest, ReadAllAdvanceFirst_NeverDefer) {
multibuffer_.SetRangeSupported(true);
MultiBufferReader reader(&multibuffer_, pos, end,
base::Callback<void(int64_t, int64_t)>());
- reader.SetMaxBuffer(2000, 5000);
+ reader.SetPinRange(2000, 5000);
reader.SetPreload(1000, 1000);
while (pos < end) {
unsigned char buffer[27];
@@ -355,7 +355,7 @@ TEST_F(MultiBufferTest, ReadAllAdvanceFirst_NeverDefer2) {
multibuffer_.SetMaxBlocksAfterDefer(-10000);
MultiBufferReader reader(&multibuffer_, pos, end,
base::Callback<void(int64_t, int64_t)>());
- reader.SetMaxBuffer(2000, 5000);
+ reader.SetPinRange(2000, 5000);
reader.SetPreload(1000, 1000);
while (pos < end) {
unsigned char buffer[27];
@@ -462,7 +462,7 @@ class ReadHelper {
pos_,
end_,
base::Callback<void(int64_t, int64_t)>()) {
- reader_.SetMaxBuffer(2000, 5000);
+ reader_.SetPinRange(2000, 5000);
reader_.SetPreload(1000, 1000);
}
« no previous file with comments | « media/blink/multibuffer_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698