Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: media/blink/multibuffer_reader.cc

Issue 1954493002: Tweak multibuffer buffering strategy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/multibuffer_reader.h ('k') | media/blink/multibuffer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_reader.cc
diff --git a/media/blink/multibuffer_reader.cc b/media/blink/multibuffer_reader.cc
index 1872110112e49c866cfc94a97e2228c0db8db96d..166de54ce959557bfd7730baa9fa2d1da055444c 100644
--- a/media/blink/multibuffer_reader.cc
+++ b/media/blink/multibuffer_reader.cc
@@ -24,6 +24,7 @@ MultiBufferReader::MultiBufferReader(
preload_low_(0),
max_buffer_forward_(0),
max_buffer_backward_(0),
+ current_buffer_size_(0),
pinned_range_(0, 0),
pos_(start),
preload_pos_(-1),
@@ -38,8 +39,7 @@ MultiBufferReader::MultiBufferReader(
MultiBufferReader::~MultiBufferReader() {
PinRange(0, 0);
multibuffer_->RemoveReader(preload_pos_, this);
- multibuffer_->IncrementMaxSize(
- -block_ceil(max_buffer_forward_ + max_buffer_backward_));
+ multibuffer_->IncrementMaxSize(-current_buffer_size_);
multibuffer_->CleanupWriters(preload_pos_);
}
@@ -58,17 +58,19 @@ void MultiBufferReader::Seek(int64_t pos) {
multibuffer_->CleanupWriters(old_preload_pos);
}
-void MultiBufferReader::SetMaxBuffer(int64_t backward, int64_t forward) {
+void MultiBufferReader::SetMaxBuffer(int64_t buffer_size) {
+ // Safe, because we know this doesn't actually prune the cache right away.
+ int64_t new_buffer_size = block_ceil(buffer_size);
+ multibuffer_->IncrementMaxSize(new_buffer_size - current_buffer_size_);
+ current_buffer_size_ = new_buffer_size;
+}
+
+void MultiBufferReader::SetPinRange(int64_t backward, int64_t forward) {
// Safe, because we know this doesn't actually prune the cache right away.
- multibuffer_->IncrementMaxSize(
- -block_ceil(max_buffer_forward_ + max_buffer_backward_));
max_buffer_backward_ = backward;
max_buffer_forward_ = forward;
PinRange(block(pos_ - max_buffer_backward_),
block_ceil(pos_ + max_buffer_forward_));
-
- multibuffer_->IncrementMaxSize(
- block_ceil(max_buffer_forward_ + max_buffer_backward_));
}
int64_t MultiBufferReader::Available() const {
« no previous file with comments | « media/blink/multibuffer_reader.h ('k') | media/blink/multibuffer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698