Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1954423002: DevTools: introduce CSSStyleSheetHeader.originalContentProvider() method (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simplify-network-project
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce CSSStyleSheetHeader.originalContentProvider() method This patch adds CSSStyleSheetHeader.originalContentProvider() method, which returns a content provider of original CSSStyleSheetHeader content. This provider is used to: - populate Workspace - build initial mapping for LiveSASS BUG=610061 R=pfeldman Committed: https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2 Cr-Commit-Position: refs/heads/master@{#392787}

Patch Set 1 #

Patch Set 2 : add testcase #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -72 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/search/search-in-static.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-inspector-stylesheet.html View 1 2 2 chunks +9 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/keyframes-source-offsets.html View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider.html View 1 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider-expected.txt View 1 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js View 1 2 3 4 3 chunks +15 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sass/SASSSourceMapFactory.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 2 9 chunks +44 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js View 1 2 3 4 3 chunks +75 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 2 3 4 1 chunk +12 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
lushnikov
Please, take a look
4 years, 7 months ago (2016-05-10 07:32:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954423002/60001
4 years, 7 months ago (2016-05-10 07:32:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 10:56:40 UTC) #8
dgozman
lgtm https://codereview.chromium.org/1954423002/diff/60001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1954423002/diff/60001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode51 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:51: this._sectionBlocks = []; Annotate? https://codereview.chromium.org/1954423002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js (right): ...
4 years, 7 months ago (2016-05-10 18:09:37 UTC) #9
lushnikov
https://codereview.chromium.org/1954423002/diff/60001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/1954423002/diff/60001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode51 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:51: this._sectionBlocks = []; On 2016/05/10 18:09:37, dgozman wrote: > ...
4 years, 7 months ago (2016-05-10 20:16:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954423002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954423002/80001
4 years, 7 months ago (2016-05-10 20:17:33 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-11 00:34:04 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 00:35:46 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2
Cr-Commit-Position: refs/heads/master@{#392787}

Powered by Google App Engine
This is Rietveld 408576698