Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1954413002: MD Settings: inline bluetooth_dialog_shared_css.html now that it's only (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-polish1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: inline bluetooth_dialog_shared_css.html now that it's only used in 1 place. R=stevenjb@chromium.org BUG=602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f7f6b761518b0450d53a5e0db65df71a1f62855d Cr-Commit-Position: refs/heads/master@{#393110}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : git rm #

Patch Set 4 : merge #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -98 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 1 2 3 4 1 chunk +89 lines, -2 lines 0 comments Download
D chrome/browser/resources/settings/bluetooth_page/bluetooth_dialog_shared_css.html View 1 2 1 chunk +0 lines, -93 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Dan Beam
4 years, 7 months ago (2016-05-07 03:13:49 UTC) #2
stevenjb
https://codereview.chromium.org/1954413002/diff/1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html (right): https://codereview.chromium.org/1954413002/diff/1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html#newcode96 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:96: </style> If inlining CSS is the preference (requirement? I ...
4 years, 7 months ago (2016-05-09 17:02:57 UTC) #3
Dan Beam
https://codereview.chromium.org/1954413002/diff/1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html (right): https://codereview.chromium.org/1954413002/diff/1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html#newcode96 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:96: </style> On 2016/05/09 17:02:57, stevenjb wrote: > If inlining ...
4 years, 7 months ago (2016-05-09 18:27:37 UTC) #4
stevenjb
I assume we'll look into sharing CSS properties in the next pass when we use ...
4 years, 7 months ago (2016-05-11 16:41:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954413002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954413002/80001
4 years, 7 months ago (2016-05-11 23:50:15 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-11 23:54:35 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 23:55:59 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f7f6b761518b0450d53a5e0db65df71a1f62855d
Cr-Commit-Position: refs/heads/master@{#393110}

Powered by Google App Engine
This is Rietveld 408576698