MD Settings: combine bluetooth adding and pairing dialogs into one

MD Settings: combine bluetooth adding and pairing dialogs into one
<settings-dialog>

This CL is intentionally meant to do as little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d
Cr-Commit-Position: refs/heads/master@{#393102}

[Dan Beam, 2016-05-07 01:06:19]

Description was changed from

==========
MD Settings: polish bluetooth dialogs by harnessing <settings-dialog>

R=stevenjb@chromium.org
BUG=602538
==========

to

==========
MD Settings: polish bluetooth dialogs by harnessing <settings-dialog>

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-07 01:41:16]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-05-07 01:43:41]

Description was changed from

==========
MD Settings: polish bluetooth dialogs by harnessing <settings-dialog>

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine adding and pairing dialog in one <settings-dialog>

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-07 02:03:44]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2016-05-07 02:04:50]

Description was changed from

==========
MD Settings: combine adding and pairing dialog in one <settings-dialog>

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine adding and pairing dialog in one <settings-dialog>

This CL is intentionally meant to do at little modification of the existing
code as possible, but mainly to combine and iterate. There are many visual
issues caused by this CL that will live very temporarily.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-07 03:02:35]

Patchset #1 (id:40001) has been deleted

[Dan Beam, 2016-05-07 03:04:59]

Description was changed from

==========
MD Settings: combine adding and pairing dialog in one <settings-dialog>

This CL is intentionally meant to do at little modification of the existing
code as possible, but mainly to combine and iterate. There are many visual
issues caused by this CL that will live very temporarily.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one
<settings-dialog>

This CL is intentionally meant to do at little modification of the existing
code as possible, but mainly to combine and iterate. There are many visual
issues caused by this CL that will live very temporarily.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-07 03:07:03]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one
<settings-dialog>

This CL is intentionally meant to do at little modification of the existing
code as possible, but mainly to combine and iterate. There are many visual
issues caused by this CL that will live very temporarily.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one
<settings-dialog>

This CL is intentionally meant to do at little modification of the existing
code as possible, but mainly to combine and iterate. There are many visual
issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in
bluetooth_device_dialog.html

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-07 03:07:52]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one
<settings-dialog>

This CL is intentionally meant to do at little modification of the existing
code as possible, but mainly to combine and iterate. There are many visual
issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in
bluetooth_device_dialog.html

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do at little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.
==========

[Dan Beam, 2016-05-07 03:08:07]

step #1

[Dan Beam, 2016-05-07 03:13:21]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do at little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do at little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
==========

[stevenjb, 2016-05-09 16:58:10]

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:22:
</div>
This bit really seems like it ought to be shared between the dialogs if we are
going to glom them into a single html file.

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:51:
class="settings-blox layout vertical center center-justified flex">
Are we enforcing 80 cols in the html?

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:16:
dialog: String,
I was confused by |dialog| in the html, maybe dialogType?

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:18:
// ================================== Add ======================================
The necessity of these comments for readability suggests to me that we should
move the add / pair logic to behaviors and just inlcude those behaviors here.

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:70:
isDialog_: function(currentDialog, wantedDialog) {
Types for num-member args?

[Dan Beam, 2016-05-10 23:08:48]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do at little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do at little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-10 23:38:54]

Patchset #2 (id:80001) has been deleted

[Dan Beam, 2016-05-10 23:54:15]

Patchset #2 (id:100001) has been deleted

[Dan Beam, 2016-05-10 23:55:22]

thank you for the behavior idea!  it looks much better this way

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:22:
</div>
On 2016/05/09 16:58:10, stevenjb wrote:
> This bit really seems like it ought to be shared between the dialogs if we are
> going to glom them into a single html file.
> 

it will be (<settings-dialog> has its own)

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:51:
class="settings-blox layout vertical center center-justified flex">
On 2016/05/09 16:58:10, stevenjb wrote:
> Are we enforcing 80 cols in the html?

Done.

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
(right):

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:16:
dialog: String,
On 2016/05/09 16:58:10, stevenjb wrote:
> I was confused by |dialog| in the html, maybe dialogType?

Done.

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:18:
// ================================== Add ======================================
On 2016/05/09 16:58:10, stevenjb wrote:
> The necessity of these comments for readability suggests to me that we should
> move the add / pair logic to behaviors and just inlcude those behaviors here.

Done.

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js:70:
isDialog_: function(currentDialog, wantedDialog) {
On 2016/05/09 16:58:10, stevenjb wrote:
> Types for num-member args?

Done.

[stevenjb, 2016-05-11 16:30:07]

Thanks! lgtm.

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/1954383002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:22:
</div>
On 2016/05/10 23:55:22, Dan Beam wrote:
> On 2016/05/09 16:58:10, stevenjb wrote:
> > This bit really seems like it ought to be shared between the dialogs if we
are
> > going to glom them into a single html file.
> > 
> 
> it will be (<settings-dialog> has its own)

Acknowledged.

[Dan Beam, 2016-05-11 19:05:40]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-05-11 19:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954383002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954383002/120001

[commit-bot: I haz the power, 2016-05-11 19:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 19:09:19]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2016-05-11 19:13:19]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-05-11 19:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1954383002/#ps140001
(title: "merge")

[commit-bot: I haz the power, 2016-05-11 19:13:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954383002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954383002/140001

[Dan Beam, 2016-05-11 19:19:08]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-05-11 19:27:11]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-05-11 19:27:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1954383002/#ps160001
(title: "git rm more things")

[commit-bot: I haz the power, 2016-05-11 19:27:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954383002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954383002/160001

[commit-bot: I haz the power, 2016-05-11 20:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 20:43:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-05-11 21:56:35]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do at little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do as little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-11 22:01:09]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-05-11 22:01:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1954383002/#ps180001
(title: "whoops, html deps")

[commit-bot: I haz the power, 2016-05-11 22:01:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954383002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954383002/180001

[commit-bot: I haz the power, 2016-05-11 23:19:59]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do as little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do as little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-11 23:20:01]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2016-05-11 23:22:18]

Description was changed from

==========
MD Settings: combine bluetooth adding and pairing dialogs into one 
<settings-dialog>

This CL is intentionally meant to do as little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in          
                                                   
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: combine bluetooth adding and pairing dialogs into one
<settings-dialog>

This CL is intentionally meant to do as little modification of the
existing code as possible, but mainly to combine and iterate. There are
many visual issues caused by this CL that will live very temporarily.

Next step: move bluetooth_dialog_shared_css.html into a <style> tag in
bluetooth_device_dialog.html.

R=stevenjb@chromium.org
BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d
Cr-Commit-Position: refs/heads/master@{#393102}
==========

[commit-bot: I haz the power, 2016-05-11 23:22:20]

Patchset 5 (id:??) landed as
https://crrev.com/55403528a28add7cec94a81bbef29a42ee6dee6d
Cr-Commit-Position: refs/heads/master@{#393102}