Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_ast.dart

Issue 1954203002: Keep all type arguments in summaries - dynamic or not. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_ast.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_ast.dart b/pkg/analyzer/lib/src/summary/summarize_ast.dart
index 35c6d011ba81d0eb0732351769fc6de041ca4c56..8b8d5a23074bcfebf51cf0a685a522af2d7f1fae 100644
--- a/pkg/analyzer/lib/src/summary/summarize_ast.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_ast.dart
@@ -793,20 +793,8 @@ class _SummarizeAstVisitor extends RecursiveAstVisitor {
'Unexpected identifier type: ${identifier.runtimeType}');
}
if (typeArguments != null) {
- // Trailing type arguments of type 'dynamic' should be omitted.
- NodeList<TypeName> args = typeArguments.arguments;
- int numArgsToSerialize = args.length;
- while (
- numArgsToSerialize > 0 && isDynamic(args[numArgsToSerialize - 1])) {
- --numArgsToSerialize;
- }
- if (numArgsToSerialize > 0) {
- List<EntityRefBuilder> serializedArguments = <EntityRefBuilder>[];
- for (int i = 0; i < numArgsToSerialize; i++) {
- serializedArguments.add(serializeTypeName(args[i]));
- }
- b.typeArguments = serializedArguments;
- }
+ b.typeArguments =
+ typeArguments.arguments.map(serializeTypeName).toList();
}
return b;
}

Powered by Google App Engine
This is Rietveld 408576698