Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 1954203002: Keep all type arguments in summaries - dynamic or not. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/idl.dart
diff --git a/pkg/analyzer/lib/src/summary/idl.dart b/pkg/analyzer/lib/src/summary/idl.dart
index 5d7174a8e67fc0c25c274d2a844b121bfb90a7b5..31c65655073dd4bc914c048ec78f8591f8669fa5 100644
--- a/pkg/analyzer/lib/src/summary/idl.dart
+++ b/pkg/analyzer/lib/src/summary/idl.dart
@@ -202,8 +202,9 @@ abstract class EntityRef extends base.SummaryClass {
/**
* If this is an instantiation of a generic type or generic executable, the
- * type arguments used to instantiate it. Trailing type arguments of type
- * `dynamic` are omitted.
+ * type arguments used to instantiate it. If AST is used to create the
Paul Berry 2016/05/06 18:11:38 IMO, the documentation in this file should specify
scheglov 2016/05/06 19:12:36 Done.
+ * summary, and the AST does not specify any type arguments, this list is
+ * empty. If element model is used, this list is not empty.
*/
@Id(1)
List<EntityRef> get typeArguments;

Powered by Google App Engine
This is Rietveld 408576698