Keep all type arguments in summaries - dynamic or not.

Keep all type arguments in summaries - dynamic or not.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/4db64c34fe296ff3ab8f4952b3471272f0f5691a

[Paul Berry, 2016-05-06 18:11:38]

lgtm assuming you are ok with my suggestions below.

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:205: * type arguments used to instantiate
it.  If AST is used to create the
IMO, the documentation in this file should specify what happens with AST
summaries, and should not mention what happens with element-based summaries. 
Rationale: the behavior of element-based summaries is a bug caused by the fact
that the element model doesn't allow us to tell the difference between implicit
and explicit type arguments; that bug should be documented in the element-based
summary code (and tests), not here.

So personally I would just say "If this is an instantiation of a generic type or
generic executable, the type arguments used to instantiate it (if any)."

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:168: bool get elementMode;
This is redundant.  Use `!checkAstDerivedData` instead (which is equivalent).

[scheglov, 2016-05-06 19:12:36]

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:205: * type arguments used to instantiate
it.  If AST is used to create the
On 2016/05/06 18:11:38, Paul Berry wrote:
> IMO, the documentation in this file should specify what happens with AST
> summaries, and should not mention what happens with element-based summaries. 
> Rationale: the behavior of element-based summaries is a bug caused by the fact
> that the element model doesn't allow us to tell the difference between
implicit
> and explicit type arguments; that bug should be documented in the
element-based
> summary code (and tests), not here.
> 
> So personally I would just say "If this is an instantiation of a generic type
or
> generic executable, the type arguments used to instantiate it (if any)."

Done.

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1954203002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:168: bool get elementMode;
On 2016/05/06 18:11:38, Paul Berry wrote:
> This is redundant.  Use `!checkAstDerivedData` instead (which is equivalent).

Done.

[scheglov, 2016-05-06 19:13:08]

Description was changed from

==========
Keep all type arguments in summaries - dynamic or not.

R=paulberry@google.com
BUG=
==========

to

==========
Keep all type arguments in summaries - dynamic or not.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/4db64c34fe296ff3ab8f4952b3471272f0f5691a
==========

[scheglov, 2016-05-06 19:13:09]

Committed patchset #2 (id:20001) manually as
4db64c34fe296ff3ab8f4952b3471272f0f5691a (presubmit successful).