Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_elements.dart

Issue 1954203002: Keep all type arguments in summaries - dynamic or not. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweaks Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | pkg/analyzer/test/src/summary/summary_common.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/summarize_elements.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_elements.dart b/pkg/analyzer/lib/src/summary/summarize_elements.dart
index 92388eeb85bfe915b1ae28e250cd7ecaeeff7371..3e48a4ed0d71db7de12256f8743ed3552b5a801e 100644
--- a/pkg/analyzer/lib/src/summary/summarize_elements.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_elements.dart
@@ -1072,20 +1072,9 @@ class _CompilationUnitSerializer {
}
List<DartType> typeArguments = getTypeArguments(type);
if (typeArguments != null) {
- // Trailing type arguments of type 'dynamic' should be omitted.
- int numArgsToSerialize = typeArguments.length;
- while (numArgsToSerialize > 0 &&
- typeArguments[numArgsToSerialize - 1].isDynamic) {
- --numArgsToSerialize;
- }
- if (numArgsToSerialize > 0) {
- List<EntityRefBuilder> serializedArguments = <EntityRefBuilder>[];
- for (int i = 0; i < numArgsToSerialize; i++) {
- serializedArguments
- .add(serializeTypeRef(typeArguments[i], context));
- }
- b.typeArguments = serializedArguments;
- }
+ b.typeArguments = typeArguments
+ .map((typeArgument) => serializeTypeRef(typeArgument, context))
+ .toList();
}
}
return b;
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | pkg/analyzer/test/src/summary/summary_common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698