Issue 19540026: DevTools: [CodeMirror] respect CRLF line endings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19540026: DevTools: [CodeMirror] respect CRLF line endings (Closed)

Created:
7 years, 5 months ago by lushnikov

Modified:
7 years, 5 months ago

Reviewers:

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [CodeMirror] respect CRLF line endings This patch adds a functionality to respect CRLF line endings in CodeMirrorTextEditor; this functionality was initially missing in it. A test to verify this behaviour is also brought in. BUG=263364

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+31 lines, -17 lines)			Patch
LayoutTests/inspector/editor/text-editor-line-breaks.html	View	2 chunks	+15 lines, -14 lines	0 comments	Download
Source/devtools/front_end/CodeMirrorTextEditor.js	View	3 chunks	+15 lines, -2 lines	0 comments	Download
Source/devtools/front_end/SourceFrame.js	View	1 chunk	+1 line, -1 line	0 comments	Download