Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 19540012: Logger: extract FLAG_log_code related logging into CodeEventLogger class. (Closed)

Created:
7 years, 5 months ago by loislo
Modified:
7 years, 5 months ago
Reviewers:
yangguo, yurys
CC:
v8-dev
Visibility:
Public.

Description

Logger: extract FLAG_log_code related logging into CodeEventLogger class. BUG=260203 TEST=current test set. No changes in the logic.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -57 lines) Patch
M src/log.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/log.cc View 17 chunks +126 lines, -57 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
loislo
7 years, 5 months ago (2013-07-18 17:49:10 UTC) #1
yurys
https://codereview.chromium.org/19540012/diff/1/src/log.cc File src/log.cc (right): https://codereview.chromium.org/19540012/diff/1/src/log.cc#newcode946 src/log.cc:946: class CodeEventLogger { I'd rather extract EventDispatcher into a ...
7 years, 5 months ago (2013-07-18 18:05:05 UTC) #2
loislo
7 years, 5 months ago (2013-07-19 06:25:10 UTC) #3
On 2013/07/18 18:05:05, Yury Semikhatsky wrote:
> https://codereview.chromium.org/19540012/diff/1/src/log.cc
> File src/log.cc (right):
> 
> https://codereview.chromium.org/19540012/diff/1/src/log.cc#newcode946
> src/log.cc:946: class CodeEventLogger {
> I'd rather extract EventDispatcher into a separate class and keep
> CodeEventLoggger a part of Logger. The Logger would become one of the event
> listener (like CpuProfiler, LowLevelLogger and others). In other words I'd
> extract event dispatching out of Logger and leave only actual logging
> functionality here. WDYT?

So, in the offline discussion we came to the conclusion that we would like to
keep the logger part in the Logger and extract the first part that uses
name_buffer_
as the storage into a separate class.

Powered by Google App Engine
This is Rietveld 408576698