Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 195393003: Enable syscall_test on windows. (Closed)

Created:
6 years, 9 months ago by Sam Clegg
Modified:
6 years, 9 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable syscall_test on windows. This test has been disabled under windows since it was first added which left these syscalls untested. I had to remove the regex_filter from this command as it was not be parsed correctly by the windows command line. However these tests pass which means that no other stderr lines are output by the test. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3808 TEST= run_syscall_test R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12878

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M src/shared/platform/win/nacl_host_desc.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/shared/platform/win/nacl_host_dir_types.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/syscalls/nacl.scons View 1 chunk +20 lines, -23 lines 0 comments Download
M tests/syscalls/syscalls.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
6 years, 9 months ago (2014-03-11 20:36:33 UTC) #1
Mark Seaborn
LGTM, thanks
6 years, 9 months ago (2014-03-11 21:34:40 UTC) #2
Sam Clegg
Worked around an issue caused by UNICODE be inconsistenly defined (use WIN32_FIND_DATAW rather than WIN32_FIND_DATA ...
6 years, 9 months ago (2014-03-12 20:34:20 UTC) #3
Mark Seaborn
LGTM
6 years, 9 months ago (2014-03-12 21:08:20 UTC) #4
Sam Clegg
6 years, 9 months ago (2014-03-12 21:25:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r12878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698