Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1953903002: Revert of Fix for 504133 - wandering identity switcher button (Closed)

Created:
4 years, 7 months ago by kylix_rd
Modified:
4 years, 7 months ago
Reviewers:
Ilya Kulshin, sky, scottmg
CC:
chromium-reviews, tfarina, scottmg, Ilya Kulshin, Bret
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix for 504133 - wandering identity switcher button (patchset #4 id:60001 of https://codereview.chromium.org/1952473002/ ) Reason for revert: Causes a regression on systems which are using a scaling factor of >100%. This includes Windows 7,8.x & 10. Will need to figure out why and how to fix a problem with the device scale factor calculation using display::win::ScreenWin.ClientToDIPPoint(); Original issue's description: > Fix for wandering identity switcher button when magnified > > BUG=504133 > > Committed: https://crrev.com/88d78eca5976e5c58f036aa0b87257653af6c1b7 > Cr-Commit-Position: refs/heads/master@{#391595} TBR=sky@chromium.org,kulshin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=504133 Committed: https://crrev.com/a2af9783d58f153891307ba49bb73b103050dbc7 Cr-Commit-Position: refs/heads/master@{#391931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -56 lines) Patch
M chrome/browser/ui/views/frame/minimize_button_metrics_win.cc View 3 chunks +27 lines, -56 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kylix_rd
Created Revert of Fix for 504133 - wandering identity switcher button
4 years, 7 months ago (2016-05-05 21:05:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953903002/1
4 years, 7 months ago (2016-05-05 21:05:38 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-05 21:05:39 UTC) #4
scottmg
lgtm
4 years, 7 months ago (2016-05-05 21:06:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953903002/1
4 years, 7 months ago (2016-05-05 21:07:23 UTC) #8
Ilya Kulshin
lgtm
4 years, 7 months ago (2016-05-05 21:39:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 22:41:28 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 22:43:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2af9783d58f153891307ba49bb73b103050dbc7
Cr-Commit-Position: refs/heads/master@{#391931}

Powered by Google App Engine
This is Rietveld 408576698