Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: tool/input_sdk/lib/async/async_error.dart

Issue 1953823005: Only use white list on indefinite checks (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/lib/async/async_error.dart
diff --git a/tool/input_sdk/lib/async/async_error.dart b/tool/input_sdk/lib/async/async_error.dart
index 2f3419e164fe023f4e844adfd3c0a9ec64bb420a..53788859fc979d9be086a5ee7c2c21f726bebfce 100644
--- a/tool/input_sdk/lib/async/async_error.dart
+++ b/tool/input_sdk/lib/async/async_error.dart
@@ -16,11 +16,21 @@ _invokeErrorHandler(Function errorHandler,
Function _registerErrorHandler/*<R>*/(Function errorHandler, Zone zone) {
if (errorHandler is ZoneBinaryCallback) {
- return zone.registerBinaryCallback/*<R, dynamic, StackTrace>*/(
- errorHandler as dynamic/*=ZoneBinaryCallback<R, dynamic, StackTrace>*/);
+ // TODO(leafp): These are commented out, because the async libraries
+ // pass a (...) -> void into this function which fails whenever R
+ // is something interesting. This needs to be sorted out in the main
+ // SDK as to what the intent is here: if this is really supposed to
+ // return an R, then the function that gets passed in is wrong. If not,
+ // then this code doesn't need to track the return type at all.
+ // return zone.registerBinaryCallback/*<R, dynamic, StackTrace>*/(
+ // errorHandler as dynamic/*=ZoneBinaryCallback<R, dynamic, StackTrace>*/);
+ return zone.registerBinaryCallback/*<dynamic, dynamic, StackTrace>*/(
+ errorHandler as dynamic/*=ZoneBinaryCallback<dynamic, dynamic, StackTrace>*/);
} else {
- return zone.registerUnaryCallback/*<R, dynamic>*/(
- errorHandler as dynamic/*=ZoneUnaryCallback<R, dynamic>*/);
+ // return zone.registerUnaryCallback/*<R, dynamic>*/(
+ // errorHandler as dynamic/*=ZoneUnaryCallback<R, dynamic>*/);
+ return zone.registerUnaryCallback/*<dynamic, dynamic>*/(
+ errorHandler as dynamic/*=ZoneUnaryCallback<dynamic, dynamic>*/);
}
}
« no previous file with comments | « test/codegen/lib/typed_data/typed_data_list_test.dart ('k') | tool/input_sdk/private/ddc_runtime/operations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698