Issue 1953803003: Fix precompile build issue with IsString change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1953803003: Fix precompile build issue with IsString change. (Closed)

Created:
4 years, 7 months ago by siva

Modified:
4 years, 7 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix precompile build issue with IsString change. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/29d79258f1be759b61ea9e6feb029232f8cbccbe

Patch Set 2 : self-review-comments #

Total comments: 1

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	runtime/vm/precompiler.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+11 lines, -8 lines	1 comment	Download
M	runtime/vm/symbols.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

lgtm https://chromiumcodereview.appspot.com/1953803003/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://chromiumcodereview.appspot.com/1953803003/diff/20001/runtime/vm/raw_object.h#newcode444 runtime/vm/raw_object.h:444: bool IsTypedDataView##clazz() const { \ IsTypedData##clazz##View then?

4 years, 7 months ago (2016-05-05 18:15:15 UTC) #3

siva

4 years, 7 months ago (2016-05-05 19:53:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
29d79258f1be759b61ea9e6feb029232f8cbccbe (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1953803003: Fix precompile build issue with IsString change. (Closed)

Description

Patch Set 1 #

Patch Set 2 : self-review-comments #

Messages