Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: runtime/vm/raw_object.h

Issue 1953803003: Fix precompile build issue with IsString change. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-review-comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/symbols.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index bada55697e0f465b212e51cc6692285ea029a340..977ba55040acdc93904c958016db44714e6dce62 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -433,27 +433,30 @@ class RawObject {
}
#define DEFINE_IS_CID(clazz) \
- bool Is##clazz() { return ((GetClassId() == k##clazz##Cid)); }
+ bool Is##clazz() const { return ((GetClassId() == k##clazz##Cid)); }
CLASS_LIST(DEFINE_IS_CID)
#undef DEFINE_IS_CID
#define DEFINE_IS_CID(clazz) \
- bool IsTypedData##clazz() { \
+ bool IsTypedData##clazz() const { \
return ((GetClassId() == kTypedData##clazz##Cid)); \
} \
- bool IsTypedDataView##clazz() { \
- return ((GetClassId() == kTypedDataView##clazz##Cid)); \
+ bool IsTypedDataView##clazz() const { \
rmacnak 2016/05/05 18:15:15 IsTypedData##clazz##View then?
+ return ((GetClassId() == kTypedData##clazz##ViewCid)); \
} \
- bool IsExternalTypedData##clazz() { \
+ bool IsExternalTypedData##clazz() const { \
return ((GetClassId() == kExternalTypedData##clazz##Cid)); \
- } \
+ }
CLASS_LIST_TYPED_DATA(DEFINE_IS_CID)
#undef DEFINE_IS_CID
- bool IsDartInstance() {
+ bool IsStringInstance() const {
+ return IsStringClassId(GetClassId());
+ }
+ bool IsDartInstance() const {
return (!IsHeapObject() || (GetClassId() >= kInstanceCid));
}
- bool IsFreeListElement() {
+ bool IsFreeListElement() const {
return ((GetClassId() == kFreeListElement));
}
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/symbols.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698