Issue 195373004: Revert "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195373004: Revert "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." (Closed)

Created:
6 years, 9 months ago by rmcilroy

Modified:
6 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." This reverts r19825 for breaking ia32.debug checks. Original Review URL: https://codereview.chromium.org/183803022 Update serializer to be able to deal with ool constant pool. TBR=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19827

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -340 lines)			Patch
M	src/a64/assembler-a64.h	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	src/a64/assembler-a64-inl.h	View	9 chunks	+12 lines, -30 lines	0 comments	Download
M	src/a64/frames-a64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/arm/assembler-arm.h	View	2 chunks	+3 lines, -21 lines	0 comments	Download
M	src/arm/assembler-arm-inl.h	View	8 chunks	+10 lines, -14 lines	0 comments	Download
M	src/debug.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/globals.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	2 chunks	+4 lines, -15 lines	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	5 chunks	+9 lines, -12 lines	0 comments	Download
M	src/ia32/frames-ia32.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/ic.h	View	11 chunks	+14 lines, -47 lines	0 comments	Download
M	src/ic.cc	View	10 chunks	+33 lines, -73 lines	0 comments	Download
M	src/ic-inl.h	View	4 chunks	+7 lines, -54 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-visiting-inl.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/serialize.cc	View	7 chunks	+19 lines, -10 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	2 chunks	+4 lines, -15 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	5 chunks	+7 lines, -10 lines	0 comments	Download
M	src/x64/frames-x64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

6 years, 9 months ago (2014-03-11 21:46:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r19827 (tree was closed).

Expand Messages | Collapse Messages