Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: src/a64/assembler-a64.h

Issue 195373004: Revert "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/assembler-a64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 // RelocInfo and pools ------------------------------------------------------ 773 // RelocInfo and pools ------------------------------------------------------
774 774
775 // Record relocation information for current pc_. 775 // Record relocation information for current pc_.
776 void RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data = 0); 776 void RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data = 0);
777 777
778 // Return the address in the constant pool of the code target address used by 778 // Return the address in the constant pool of the code target address used by
779 // the branch/call instruction at pc. 779 // the branch/call instruction at pc.
780 inline static Address target_pointer_address_at(Address pc); 780 inline static Address target_pointer_address_at(Address pc);
781 781
782 // Read/Modify the code target address in the branch/call instruction at pc. 782 // Read/Modify the code target address in the branch/call instruction at pc.
783 inline static Address target_address_at(Address pc, 783 inline static Address target_address_at(Address pc);
784 ConstantPoolArray* constant_pool); 784 inline static void set_target_address_at(Address pc, Address target);
785 inline static void set_target_address_at(Address pc,
786 ConstantPoolArray* constant_pool,
787 Address target);
788 static inline Address target_address_at(Address pc, Code* code);
789 static inline void set_target_address_at(Address pc,
790 Code* code,
791 Address target);
792 785
793 // Return the code target address at a call site from the return address of 786 // Return the code target address at a call site from the return address of
794 // that call in the instruction stream. 787 // that call in the instruction stream.
795 inline static Address target_address_from_return_address(Address pc); 788 inline static Address target_address_from_return_address(Address pc);
796 789
797 // Given the address of the beginning of a call, return the address in the 790 // Given the address of the beginning of a call, return the address in the
798 // instruction stream that call will return from. 791 // instruction stream that call will return from.
799 inline static Address return_address_from_call_start(Address pc); 792 inline static Address return_address_from_call_start(Address pc);
800 793
801 // This sets the branch destination (which is in the constant pool on ARM). 794 // This sets the branch destination (which is in the constant pool on ARM).
802 // This is for calls and branches within generated code. 795 // This is for calls and branches within generated code.
803 inline static void deserialization_set_special_target_at( 796 inline static void deserialization_set_special_target_at(
804 Address constant_pool_entry, Code* code, Address target); 797 Address constant_pool_entry, Address target);
805 798
806 // All addresses in the constant pool are the same size as pointers. 799 // All addresses in the constant pool are the same size as pointers.
807 static const int kSpecialTargetSize = kPointerSize; 800 static const int kSpecialTargetSize = kPointerSize;
808 801
809 // The sizes of the call sequences emitted by MacroAssembler::Call. 802 // The sizes of the call sequences emitted by MacroAssembler::Call.
810 // Wherever possible, use MacroAssembler::CallSize instead of these constants, 803 // Wherever possible, use MacroAssembler::CallSize instead of these constants,
811 // as it will choose the correct value for a given relocation mode. 804 // as it will choose the correct value for a given relocation mode.
812 // 805 //
813 // Without relocation: 806 // Without relocation:
814 // movz ip0, #(target & 0x000000000000ffff) 807 // movz ip0, #(target & 0x000000000000ffff)
(...skipping 1381 matching lines...) Expand 10 before | Expand all | Expand 10 after
2196 class EnsureSpace BASE_EMBEDDED { 2189 class EnsureSpace BASE_EMBEDDED {
2197 public: 2190 public:
2198 explicit EnsureSpace(Assembler* assembler) { 2191 explicit EnsureSpace(Assembler* assembler) {
2199 assembler->CheckBuffer(); 2192 assembler->CheckBuffer();
2200 } 2193 }
2201 }; 2194 };
2202 2195
2203 } } // namespace v8::internal 2196 } } // namespace v8::internal
2204 2197
2205 #endif // V8_A64_ASSEMBLER_A64_H_ 2198 #endif // V8_A64_ASSEMBLER_A64_H_
OLDNEW
« no previous file with comments | « no previous file | src/a64/assembler-a64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698