components/page_load_metrics/browser/metrics_web_contents_observer.cc - Issue 1953673003: Log an immediate variant of FirstContentfulPaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1953673003: Log an immediate variant of FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc

index c0da0d4e8bea0b866280b95ebd29982e26f91d5d..68961428fc8ceb311c317e9fa4e6cbdfac4eec62 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc

@@ -352,6 +352,10 @@ bool PageLoadTracker::UpdateTiming(const PageLoadTiming& new_timing,

valid_behavior_descendent) {

timing_ = new_timing;

metadata_ = new_metadata;

+ const PageLoadExtraInfo info = GetPageLoadMetricsInfo();

+ for (const auto& observer : observers_) {

+ observer->OnTimingUpdate(timing_, info);

+ }

return true;

}

return false;