Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 1953673003: Log an immediate variant of FirstContentfulPaint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index 922fa5620c11c1e8fff25a1d9d4f14441bb37a7f..eefc6bf6ded56b4255814bcace6ee330f876040b 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -134,6 +134,16 @@ TEST_F(CorePageLoadMetricsObserverTest, MultipleMetricsAfterCommits) {
NavigateAndCommit(GURL(kDefaultTestUrl));
SimulateTimingUpdate(timing);
+ // Verify that the non-immediate FCP has not yet been logged, but the
+ // immediate FCP is logged before the next navigation.
+ histogram_tester().ExpectTotalCount(internal::kHistogramFirstContentfulPaint,
+ 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramFirstContentfulPaintImmediate, 1);
+ histogram_tester().ExpectBucketCount(
+ internal::kHistogramFirstContentfulPaintImmediate,
+ first_contentful_paint.InMilliseconds(), 1);
+
NavigateAndCommit(GURL(kDefaultTestUrl2));
page_load_metrics::PageLoadTiming timing2;
@@ -159,6 +169,17 @@ TEST_F(CorePageLoadMetricsObserverTest, MultipleMetricsAfterCommits) {
internal::kHistogramDomLoadingToDomContentLoaded,
(dom_content - dom_loading).InMilliseconds(), 1);
+ histogram_tester().ExpectTotalCount(internal::kHistogramFirstContentfulPaint,
+ 1);
+ histogram_tester().ExpectBucketCount(internal::kHistogramFirstContentfulPaint,
+ first_contentful_paint.InMilliseconds(),
+ 1);
+
+ // Verify that no additional immediate metrics were logged as a result of
+ // navigation.
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramFirstContentfulPaintImmediate, 1);
+
histogram_tester().ExpectTotalCount(
internal::kHistogramDomLoadingToFirstContentfulPaint, 1);
histogram_tester().ExpectBucketCount(

Powered by Google App Engine
This is Rietveld 408576698