Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1953653002: [DevTools] Remove warning note for proxy (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-completion-for-proxy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove warning note for proxy Since Runtime.getProperties doesn't produce side effects for proxies we can remove this note. BUG=139774 R=lushnikov@chromium.org Committed: https://crrev.com/cf76b490e1e26169ab6815f0f5954dae4b86ec9b Cr-Commit-Position: refs/heads/master@{#391770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-proxy.html View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 chunk +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Issue 1952553002 Patch 80001

Messages

Total messages: 9 (4 generated)
kozy
Andrey, please take a look!
4 years, 7 months ago (2016-05-05 01:09:47 UTC) #1
lushnikov
lgtm
4 years, 7 months ago (2016-05-05 02:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953653002/1
4 years, 7 months ago (2016-05-05 05:09:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 06:25:49 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 06:27:00 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cf76b490e1e26169ab6815f0f5954dae4b86ec9b
Cr-Commit-Position: refs/heads/master@{#391770}

Powered by Google App Engine
This is Rietveld 408576698