SkOncePtr -> SkOnce

SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores()
outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1953533002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/9bd3fc7fa9bb7cad050bd619aa93d4c48ebb5c02

Committed: https://skia.googlesource.com/skia/+/ffa4a9213b4e754adc210fa02a3c4b1ae8d3b6d0

[mtklein_C, 2016-05-04 19:46:24]

Description was changed from

==========
SkOncePtr -> SkOnce

 - the only remaining use of SkOncePtr is SkTime.cpp,
   which I'm removing in another CL.

BUG=skia:
==========

to

==========
SkOncePtr -> SkOnce

 - the only remaining use of SkOncePtr is SkTime.cpp,
   which I'm removing in another CL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-05-04 19:49:08]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 19:49:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/1

[mtklein_C, 2016-05-04 19:50:01]

Description was changed from

==========
SkOncePtr -> SkOnce

 - the only remaining use of SkOncePtr is SkTime.cpp,
   which I'm removing in another CL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkOncePtr -> SkOnce

 - the only remaining use of SkOncePtr is SkTime.cpp,
   which I'm removing in another CL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-05-04 20:25:02]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 20:25:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/20001

[commit-bot: I haz the power, 2016-05-04 20:43:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 20:43:25]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-05-04 21:03:46]

Description was changed from

==========
SkOncePtr -> SkOnce

 - the only remaining use of SkOncePtr is SkTime.cpp,
   which I'm removing in another CL.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
I think this code reads more clearly to boot.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-05-04 21:06:19]

Description was changed from

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
I think this code reads more clearly to boot.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
While less terse, I think this new code reads more clearly too.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-05-04 21:06:41]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 21:06:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/40001

[mtklein_C, 2016-05-04 21:15:03]

Description was changed from

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
While less terse, I think this new code reads more clearly too.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
While less terse, I think this new code reads more clearly too.

... and, SkOncePtr's tests were the only thing now using sk_num_cores() outside
of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-05-04 21:15:18]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 21:15:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/60001

[mtklein_C, 2016-05-04 21:15:36]

Description was changed from

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
While less terse, I think this new code reads more clearly too.

... and, SkOncePtr's tests were the only thing now using sk_num_cores() outside
of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores() outside
of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-05-04 21:15:43]

Description was changed from

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores() outside
of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores()
outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[commit-bot: I haz the power, 2016-05-04 21:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:26:55]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-05-04 21:29:08]

mtklein@chromium.org changed reviewers:
+ herb@google.com
- mtklein@google.com

[mtklein_C, 2016-05-04 21:29:09]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:29:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/60001

[commit-bot: I haz the power, 2016-05-04 21:29:15]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-05-05 03:29 UTC

[herb_g, 2016-05-04 21:39:33]

lgtm

[commit-bot: I haz the power, 2016-05-04 21:40:20]

Description was changed from

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores()
outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores()
outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/9bd3fc7fa9bb7cad050bd619aa93d4c48ebb5c02
==========

[commit-bot: I haz the power, 2016-05-04 21:40:21]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9bd3fc7fa9bb7cad050bd619aa93d4c48ebb5c02

[reed1, 2016-05-05 00:14:27]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1945293004/ by reed@google.com.

The reason for reverting is: broken the Mac and Linux builders, e.g.:

https://build.chromium.org/p/chromium/builders/Mac/builds/15151
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/19052.

[mtklein, 2016-05-05 13:27:21]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 13:27:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/80001

[mtklein, 2016-05-05 13:27:33]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2016-05-05 16:24:34]

Patchset #6 (id:100001) has been deleted

[mtklein, 2016-05-05 16:24:39]

Patchset #5 (id:80001) has been deleted

[mtklein, 2016-05-05 22:51:19]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-05-05 22:51:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953533002/60001

[commit-bot: I haz the power, 2016-05-05 23:05:59]

Description was changed from

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores()
outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/9bd3fc7fa9bb7cad050bd619aa93d4c48ebb5c02
==========

to

==========
SkOncePtr -> SkOnce

It's always nice to kill off a synchronization primitive.
And while less terse, I think this new code reads more clearly.

... and, SkOncePtr's tests were the only thing now using sk_num_cores()
outside of SkTaskGroup, so I've hidden it as static inside SkTaskGroup.cpp.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/9bd3fc7fa9bb7cad050bd619aa93d4c48ebb5c02

Committed:
https://skia.googlesource.com/skia/+/ffa4a9213b4e754adc210fa02a3c4b1ae8d3b6d0
==========

[commit-bot: I haz the power, 2016-05-05 23:06:02]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ffa4a9213b4e754adc210fa02a3c4b1ae8d3b6d0