Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3107)

Unified Diff: build/config/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 0be6d904aed37e573994d3034e16499abadabc15..dbb38d3ef16d01e5d0573cd17e554ca56210f55a 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -13,7 +13,7 @@ import("//build/toolchain/goma.gni")
# One common error that happens is that GYP-generated headers within gen/ get
# included rather than the GN-generated ones within gen/ subdirectories.
-# TODO(agrieve): Remove once GYP is gone (as well as exec_script exception).
+# TODO(GYP_GONE): Remove once GYP is gone (as well as exec_script exception).
assert(
exec_script("//build/dir_exists.py", [ "obj.host" ], "string") == "False",
"GYP artifacts detected in $root_build_dir.$0x0A" +
@@ -48,10 +48,8 @@ declare_args() {
#
# For now we define these globally to match the current GYP build.
config("feature_flags") {
- # TODO(brettw) this probably needs to be parameterized.
brettw 2016/05/04 19:51:28 We can parameterize this if and when we need it.
- defines = [
- "V8_DEPRECATION_WARNINGS", # Don't use deprecated V8 APIs anywhere.
- ]
+ # Don't use deprecated V8 APIs anywhere.
+ defines = [ "V8_DEPRECATION_WARNINGS" ]
if (enable_mdns) {
defines += [ "ENABLE_MDNS=1" ]
}
@@ -293,8 +291,6 @@ config("release") {
defines = [ "NDEBUG" ]
# Sanitizers.
- # TODO(GYP) The GYP build has "release_valgrind_build == 0" for this
brettw 2016/05/04 19:51:28 Valgrind is gone.
- # condition. When Valgrind is set up, we need to do the same here.
if (is_tsan) {
defines += [
"DYNAMIC_ANNOTATIONS_ENABLED=1",

Powered by Google App Engine
This is Rietveld 408576698