Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1953483002: Revert of Do V8 GC ASAP if system memory is pressured (Closed)

Created:
4 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
4 years, 7 months ago
CC:
esprehn, chromium-reviews, darin-cc_chromium.org, gavinp+memory_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do V8 GC ASAP if system memory is pressured (patchset #13 id:240001 of https://codereview.chromium.org/1749073002/ ) Reason for revert: Crash in CallOnForegroundThread BUG=609056 Original issue's description: > Do V8 GC ASAP if system memory is pressured > > Currently after receiving memory pressure notification, Chrome posts > asynchronous task to renderer main thread to trigger V8 GC. If renderer > main thread is busy, purging memory task will be postponed running, > which increases OOM risk. > > The CL can send memory pressure notification to renderer main thread > synchronously and trigger V8 GC while V8 is in the middle of executing > JavaScript. > > The CL depends on CL 1813963002 > > BUG=590975 > > Committed: https://crrev.com/f80422e52658fd87d4159bfeeddd703bae1d4180 > Cr-Commit-Position: refs/heads/master@{#391167} TBR=esprehn@chromium.org,jochen@chromium.org,kinuko@chromium.org,mark@chromium.org,rmcilroy@chromium.org,ulan@chromium.org,hong.zheng@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=590975 Committed: https://crrev.com/78980b9332da0264f52bd4ff0b6aeef23cdc21e9 Cr-Commit-Position: refs/heads/master@{#391636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -163 lines) Patch
M base/memory/memory_pressure_listener.h View 2 chunks +5 lines, -12 lines 0 comments Download
M base/memory/memory_pressure_listener.cc View 3 chunks +22 lines, -58 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +22 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 3 chunks +0 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebKit.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Vitaly Buka (NO REVIEWS)
Created Revert of Do V8 GC ASAP if system memory is pressured
4 years, 7 months ago (2016-05-04 17:30:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 17:30:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 17:31:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 18:02:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 18:08:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 18:32:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 19:02:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953483002/1
4 years, 7 months ago (2016-05-04 20:36:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 20:51:00 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:52:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78980b9332da0264f52bd4ff0b6aeef23cdc21e9
Cr-Commit-Position: refs/heads/master@{#391636}

Powered by Google App Engine
This is Rietveld 408576698