content/renderer/render_thread_impl.h - Issue 19534002: Make RendererGpuVideoDecoderFactories live on arbitrary threads.

Unified Diff: content/renderer/render_thread_impl.h

Issue 19534002: Make RendererGpuVideoDecoderFactories live on arbitrary threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/rtc_video_decoder_factory.cc ('K') | « content/renderer/media/rtc_video_decoder_unittest.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_thread_impl.h

diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h

index 561fcf6880bcf707801e1854e56bdbcfdecdbc66..2785a95dd7eb897cc236442b36b7599533ff143f 100644

--- a/content/renderer/render_thread_impl.h

+++ b/content/renderer/render_thread_impl.h

@@ -19,8 +19,8 @@

#include "content/common/gpu/client/gpu_channel_host.h"

#include "content/common/gpu/gpu_process_launch_causes.h"

#include "content/public/renderer/render_thread.h"

+#include "content/renderer/media/renderer_gpu_video_decoder_factories.h"

#include "ipc/ipc_channel_proxy.h"

-#include "media/filters/gpu_video_decoder.h"

#include "ui/gfx/native_widget_types.h"

class GrContext;

@@ -256,7 +256,8 @@ class CONTENT_EXPORT RenderThreadImpl : public RenderThread,

// Gets gpu factories. Returns NULL if VDA is disabled or a graphics context

// cannot be obtained.

- scoped_refptr<media::GpuVideoDecoder::Factories> GetGpuFactories();

+ scoped_refptr<content::RendererGpuVideoDecoderFactories> GetGpuFactories(

scherkus (not reviewing) 2013/07/19 18:13:58 don't need content:: but... why are we returning

wuchengli 2013/07/20 06:04:14 Yes. We can. I wasn't sure if it's good to put Clo

+ scoped_refptr<base::MessageLoopProxy> factories_loop);

scherkus (not reviewing) 2013/07/19 18:13:58 update docs about |factories_loop| even though wi

scherkus (not reviewing) 2013/07/19 18:13:58 this can be const-ref

wuchengli 2013/07/20 06:04:14 Done.

// Returns a graphics context shared among all

// RendererGpuVideoDecoderFactories, or NULL on error. Context remains owned