Make RendererGpuVideoDecoderFactories live on arbitrary threads.

content/renderer/render_thread_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/memory/memory_pressure_listener.h"
 #include "base/observer_list.h"
 #include "base/strings/string16.h"
 #include "base/timer/timer.h"
 #include "build/build_config.h"
 #include "content/child/child_thread.h"
 #include "content/common/content_export.h"
 #include "content/common/gpu/client/gpu_channel_host.h"
 #include "content/common/gpu/gpu_process_launch_causes.h"
 #include "content/public/renderer/render_thread.h"
+#include "content/renderer/media/renderer_gpu_video_decoder_factories.h"
 #include "ipc/ipc_channel_proxy.h"
-#include "media/filters/gpu_video_decoder.h"
 #include "ui/gfx/native_widget_types.h"
 
 class GrContext;
 class SkBitmap;
 struct ViewMsg_New_Params;
 
 namespace WebKit {
 class WebGraphicsContext3D;
 class WebMediaStreamCenter;
 class WebMediaStreamCenterClient;
@@ skipping 215 matching lines @@
   // on the renderer's main thread.
   scoped_refptr<base::MessageLoopProxy> GetMediaThreadMessageLoopProxy();
 
   // Causes the idle handler to skip sending idle notifications
   // on the two next scheduled calls, so idle notifications are
   // not sent for at least one notification delay.
   void PostponeIdleNotification();
 
   // Gets gpu factories. Returns NULL if VDA is disabled or a graphics context
   // cannot be obtained.
-  scoped_refptr<media::GpuVideoDecoder::Factories> GetGpuFactories();
+  scoped_refptr<content::RendererGpuVideoDecoderFactories> GetGpuFactories(

[scherkus (not reviewing), 2013/07/19 18:13:58]

don't need content::

but... why are we returning the impl vs the interface?

can we get away with using just the interface?

[wuchengli, 2013/07/20 06:04:14]

Yes. We can. I wasn't sure if it's good to put Clone in the interface because
RtcVideoDecoderFactory uses it but GpuVideoDecoder doesn't. I've added Clone to
the interface and change the return type here to the interface.

+      scoped_refptr<base::MessageLoopProxy> factories_loop);

[scherkus (not reviewing), 2013/07/19 18:13:58]

update docs about |factories_loop|

even though with your latest PS |factories_loop| is always
GetMediaThreadMessageLoopProxy(), I'm OK leaving this as is otherwise it isn't
obvious at the call sites which thread this thing is running on

[scherkus (not reviewing), 2013/07/19 18:13:58]

this can be const-ref

[wuchengli, 2013/07/20 06:04:14]

Done.

[wuchengli, 2013/07/20 06:04:14]

Done.

 
   // Returns a graphics context shared among all
   // RendererGpuVideoDecoderFactories, or NULL on error.  Context remains owned
   // by this class and must be null-tested before each use to detect context
   // loss.  The returned context is only valid on the compositor thread when
   // threaded compositing is enabled.
   WebGraphicsContext3DCommandBufferImpl* GetGpuVDAContext3D();
 
   // Handle loss of the shared GpuVDAContext3D context above.
   static void OnGpuVDAContextLoss();
@@ skipping 206 matching lines @@
   HistogramCustomizer histogram_customizer_;
 
   scoped_ptr<base::MemoryPressureListener> memory_pressure_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_