Issue 1953363002: Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the cor…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1953363002: Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the cor… (Closed)

Created:
4 years, 7 months ago by jwren

Modified:
4 years, 7 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
sso://user/jwren/dart-lang@cc-27-enum-constant-completions-24759

Target Ref:
refs/heads/cc-27-enum-constant-completions-24759

Visibility:
Public.

More Reviews

Description

Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the correct enum types in named arguments. BUG=https://github.com/dart-lang/sdk/issues/24759

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -12 lines)			Patch
M	pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart	View	3 chunks	+59 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/optype.dart	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart	View	3 chunks	+33 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages