pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart - Issue 1953363002: Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the cor…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 1953363002: Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the cor… (Closed) Base URL: sso://user/jwren/dart-lang@cc-27-enum-constant-completions-24759

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/optype.dart ('k') | pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

index 08c83de9cac871e78c201cca7414f20d0b441f25..0bf8a6d03f01b451e551145ba50f8e211ffaee72 100644

--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

@@ -216,9 +216,10 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {

}

CompletionSuggestion assertSuggestEnumConst(String completion,

- {bool isDeprecated: false}) {

+ {int relevance: DART_RELEVANCE_DEFAULT, bool isDeprecated: false}) {

CompletionSuggestion suggestion =

- assertSuggest(completion, isDeprecated: isDeprecated);

+ assertSuggest(completion, relevance: relevance, isDeprecated: isDeprecated);

+ expect(suggestion.completion, completion);

expect(suggestion.isDeprecated, isDeprecated);

expect(suggestion.element.kind, protocol.ElementKind.ENUM_CONSTANT);

return suggestion;