Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1953293004:
PlatformWindowMus::SetBounds to NativeWidgetMus (Closed)
|
Created:
4 years, 7 months ago by Mark Dittmer Modified:
4 years, 7 months ago Reviewers:
sadrul CC:
chromium-reviews, tfarina, Fady Samuel Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPort PlatformWindowMus::SetBounds to NativeWidgetMus
BUG=609555
Committed: https://crrev.com/f743eaa5abac03b00a6e4cd3755848cb0300ab01
Cr-Commit-Position: refs/heads/master@{#392597}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : Test code was wrapping wrong bounds-setting function #Patch Set 4 : Drop WIP testing code #
Total comments: 4
Patch Set 5 : Do not use NOTIMPLEMENTED; add class-level comment to PlatformWindowMus #Patch Set 6 : Move OnWindowBoundsChanged; add getters to clean up MusWindowObserver #
Total comments: 2
Patch Set 7 : Cast to PlatformWindowDelegate for OnBoundsChanged #
Messages
Total messages: 38 (15 generated)
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953293004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
rebase
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953293004/20001
Test code was wrapping wrong bounds-setting function
Description was changed from ========== WIP: Port PlatformWindowMus::SetBounds to NativeWidgetMus BUG=609555 ========== to ========== Port PlatformWindowMus::SetBounds to NativeWidgetMus BUG=609555 ==========
markdittmer@chromium.org changed reviewers: + sadrul@chromium.org
Drop WIP testing code
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953293004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953293004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1953293004/diff/60001/ui/views/mus/platform_w... File ui/views/mus/platform_window_mus.cc (right): https://codereview.chromium.org/1953293004/diff/60001/ui/views/mus/platform_w... ui/views/mus/platform_window_mus.cc:132: NOTIMPLEMENTED(); Remove the NOTIMEPLEMENTED() https://codereview.chromium.org/1953293004/diff/60001/ui/views/mus/platform_w... ui/views/mus/platform_window_mus.cc:207: } Move this over into NativeWidgetMus too. i.e. move all bounds-related code from PWMus into NWMus
Do not use NOTIMPLEMENTED; add class-level comment to PlatformWindowMus
Addressed https://codereview.chromium.org/1962043002/diff/1/ui/views/mus/platform_windo... in this CL.
Move OnWindowBoundsChanged; add getters to clean up MusWindowObserver
https://codereview.chromium.org/1953293004/diff/60001/ui/views/mus/platform_w... File ui/views/mus/platform_window_mus.cc (right): https://codereview.chromium.org/1953293004/diff/60001/ui/views/mus/platform_w... ui/views/mus/platform_window_mus.cc:132: NOTIMPLEMENTED(); On 2016/05/09 18:55:54, sadrul wrote: > Remove the NOTIMEPLEMENTED() Done. https://codereview.chromium.org/1953293004/diff/60001/ui/views/mus/platform_w... ui/views/mus/platform_window_mus.cc:207: } On 2016/05/09 18:55:54, sadrul wrote: > Move this over into NativeWidgetMus too. i.e. move all bounds-related code from > PWMus into NWMus Done.
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953293004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953293004/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
lgtm https://codereview.chromium.org/1953293004/diff/100001/ui/views/mus/native_wi... File ui/views/mus/native_widget_mus.cc (right): https://codereview.chromium.org/1953293004/diff/100001/ui/views/mus/native_wi... ui/views/mus/native_widget_mus.cc:323: WindowTreeHostMus* window_tree_host() { Change this to aura::WindowTreeHost*. That should take care of the build issues on the bots.
Cast to PlatformWindowDelegate for OnBoundsChanged
The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953293004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953293004/120001
https://codereview.chromium.org/1953293004/diff/100001/ui/views/mus/native_wi... File ui/views/mus/native_widget_mus.cc (right): https://codereview.chromium.org/1953293004/diff/100001/ui/views/mus/native_wi... ui/views/mus/native_widget_mus.cc:323: WindowTreeHostMus* window_tree_host() { On 2016/05/09 20:19:46, sadrul wrote: > Change this to aura::WindowTreeHost*. That should take care of the build issues > on the bots. I believe OnBoundsChanged is part of the PlatformWindowDelegate, implemented by WindowTreeHostPlatform. Right now I'm testing out a cast to PlatformWindowDelegate.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by markdittmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/1953293004/#ps120001 (title: "Cast to PlatformWindowDelegate for OnBoundsChanged")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953293004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953293004/120001
Message was sent while issue was closed.
Description was changed from ========== Port PlatformWindowMus::SetBounds to NativeWidgetMus BUG=609555 ========== to ========== Port PlatformWindowMus::SetBounds to NativeWidgetMus BUG=609555 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Port PlatformWindowMus::SetBounds to NativeWidgetMus BUG=609555 ========== to ========== Port PlatformWindowMus::SetBounds to NativeWidgetMus BUG=609555 Committed: https://crrev.com/f743eaa5abac03b00a6e4cd3755848cb0300ab01 Cr-Commit-Position: refs/heads/master@{#392597} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/f743eaa5abac03b00a6e4cd3755848cb0300ab01 Cr-Commit-Position: refs/heads/master@{#392597} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
