PlatformWindowMus::SetBounds to NativeWidgetMus

ui/views/mus/platform_window_mus.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/mus/platform_window_mus.h"
 
 #include "base/message_loop/message_loop.h"
 #include "build/build_config.h"
 #include "components/bitmap_uploader/bitmap_uploader.h"
 #include "components/mus/public/cpp/property_type_converters.h"
@@ skipping 87 matching lines @@
 
 PlatformWindowMus::~PlatformWindowMus() {
   if (!mus_window_)
     return;
   mus_window_->RemoveObserver(this);
   mus_window_->set_input_event_handler(nullptr);
   if (!mus_window_destroyed_)
     mus_window_->Destroy();
 }
 
-void PlatformWindowMus::Activate() {
-  mus_window_->SetFocus();
-}
-
 void PlatformWindowMus::SetCursorById(mus::mojom::Cursor cursor) {
   if (last_cursor_ != cursor) {
     // The ui::PlatformWindow interface uses ui::PlatformCursor at this level,
     // instead of ui::Cursor. All of the cursor abstractions in ui right now are
     // sort of leaky; despite being nominally cross platform, they all drop down
     // to platform types almost immediately, which makes them unusable as
     // transport types.
     mus_window_->SetPredefinedCursor(cursor);
   }
 }
 
 void PlatformWindowMus::Show() {
   mus_window_->SetVisible(true);
 }
 
 void PlatformWindowMus::Hide() {
   mus_window_->SetVisible(false);
 }
 
 void PlatformWindowMus::Close() {
   NOTIMPLEMENTED();
 }
 
 void PlatformWindowMus::SetBounds(const gfx::Rect& bounds) {
-  mus_window_->SetBounds(bounds);
+  NOTIMPLEMENTED();

[sadrul, 2016/05/09 18:55:54]

Remove the NOTIMEPLEMENTED()

[Mark Dittmer, 2016/05/09 19:17:04]

Done.

 }
 
 gfx::Rect PlatformWindowMus::GetBounds() {
   return mus_window_->bounds();
 }
 
 void PlatformWindowMus::SetTitle(const base::string16& title) {
   NOTIMPLEMENTED();
 }
 
@@ skipping 54 matching lines @@
   // |this| has been destroyed at this point.
 #ifndef NDEBUG
   DCHECK(!weak_ptr);
 #endif
 }
 
 void PlatformWindowMus::OnWindowBoundsChanged(mus::Window* window,
                                               const gfx::Rect& old_bounds,
                                               const gfx::Rect& new_bounds) {
   delegate_->OnBoundsChanged(new_bounds);
 }

[sadrul, 2016/05/09 18:55:54]

Move this over into NativeWidgetMus too. i.e. move all bounds-related code from
PWMus into NWMus

[Mark Dittmer, 2016/05/09 19:17:04]

Done.

 
 void PlatformWindowMus::OnWindowFocusChanged(mus::Window* gained_focus,
                                              mus::Window* lost_focus) {
   if (gained_focus == mus_window_)
     delegate_->OnActivationChanged(true);
   else if (lost_focus == mus_window_)
     delegate_->OnActivationChanged(false);
 }
 
 void PlatformWindowMus::OnWindowPredefinedCursorChanged(
@@ skipping 51 matching lines @@
 
   std::unique_ptr<ui::Event> event = ui::Event::Clone(event_in);
   delegate_->DispatchEvent(event.get());
   // NOTE: |this| may be deleted.
 
   ack_handler.set_handled(event->handled());
   // |ack_handler| acks the event on destruction if necessary.
 }
 
 }  // namespace views