Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1953273003: Fix Android Find in Page inputType to allow gesture input (Closed)

Created:
4 years, 7 months ago by johnme
Modified:
4 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Android Find in Page inputType to allow gesture input Chrome has always set the inputType to TYPE_TEXT_VARIATION_FILTER, which is invalid. Instead we should be setting it to InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_FILTER. BUG=609847 TEST=manually verified Committed: https://crrev.com/248caf490f70600ba98228fce15b7046efcfeb74 Cr-Commit-Position: refs/heads/master@{#392254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
johnme
4 years, 7 months ago (2016-05-06 16:28:59 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-05-06 16:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953273003/1
4 years, 7 months ago (2016-05-07 11:26:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-07 12:31:09 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 12:32:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/248caf490f70600ba98228fce15b7046efcfeb74
Cr-Commit-Position: refs/heads/master@{#392254}

Powered by Google App Engine
This is Rietveld 408576698