chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java - Issue 1953273003: Fix Android Find in Page inputType to allow gesture input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

Issue 1953273003: Fix Android Find in Page inputType to allow gesture input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

index ccc4919c01a82248e3912ba1747e7e4f7d8ba15d..849c2221e7e6b2b35819fc6c33fd33dd05a4251c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

@@ -214,7 +214,7 @@ public class FindToolbar extends LinearLayout

mFindQuery = (FindQuery) findViewById(R.id.find_query);

mFindQuery.setFindToolbar(this);

- mFindQuery.setInputType(InputType.TYPE_TEXT_VARIATION_FILTER);

+ mFindQuery.setInputType(InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_FILTER);

mFindQuery.setSelectAllOnFocus(true);

mFindQuery.setOnFocusChangeListener(new View.OnFocusChangeListener() {

@Override

« no previous file with comments | « no previous file | no next file » | no next file with comments »