Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/test/base/js2gtest.gni

Issue 1953233002: Use the v8 shell instead of d8 to compile jstests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename to v8_shell Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/js_unittest_rules.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/js2gtest.gni
diff --git a/chrome/test/base/js2gtest.gni b/chrome/test/base/js2gtest.gni
index 95acf375ecc3c0a2ef404808761b4727a7b33f3b..c4fde1f4865dd02e3155c6c28264130c70037b88 100644
--- a/chrome/test/base/js2gtest.gni
+++ b/chrome/test/base/js2gtest.gni
@@ -37,10 +37,10 @@ template("js2gtest") {
sources = invoker.sources
- d8_path =
- get_label_info("//v8:d8($snapshot_toolchain)", "root_out_dir") + "/d8"
+ v8_shell_path = get_label_info("//v8:v8_shell($snapshot_toolchain)",
+ "root_out_dir") + "/v8_shell"
if (is_win) {
- d8_path += ".exe"
+ v8_shell_path += ".exe"
}
input_js = [
@@ -48,7 +48,7 @@ template("js2gtest") {
"//chrome/test/data/webui/test_api.js",
"//chrome/test/base/js2gtest.js",
]
- inputs = [ d8_path ] + input_js
+ inputs = [ v8_shell_path ] + input_js
if (defined(invoker.deps_js)) {
inputs += [ invoker.deps_js ]
}
@@ -74,7 +74,7 @@ template("js2gtest") {
}
args += [
# Need "./" for script to find binary (cur dir is not on path).
- "./" + rebase_path(d8_path, root_build_dir),
+ "./" + rebase_path(v8_shell_path, root_build_dir),
]
args += rebase_path(input_js, root_build_dir) + [ invoker.test_type ]
if (v8_use_external_startup_data) {
@@ -90,7 +90,7 @@ template("js2gtest") {
]
deps = [
- "//v8:d8($snapshot_toolchain)",
+ "//v8:v8_shell($snapshot_toolchain)",
]
if (defined(invoker.deps)) {
deps += invoker.deps
« no previous file with comments | « chrome/js_unittest_rules.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698