Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 19532006: Minor cleanup for SystemInfoStorageApiTest. (Closed)

Created:
7 years, 5 months ago by Lei Zhang
Modified:
7 years, 5 months ago
Reviewers:
Hongbo Min, hokein.wu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, hokein.wu_gmail.com
Visibility:
Public.

Description

Minor cleanup for SystemInfoStorageApiTest. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/storage/test_storage_api.js View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/storage_attachment/test_storage_api.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
7 years, 5 months ago (2013-07-23 21:47:41 UTC) #1
Lei Zhang
This probably conflicts with one of your pending changes.
7 years, 5 months ago (2013-07-23 21:50:31 UTC) #2
Hongbo Min
lgtm
7 years, 5 months ago (2013-07-24 00:17:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/19532006/1
7 years, 5 months ago (2013-07-24 08:14:07 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 10:53:23 UTC) #5
Message was sent while issue was closed.
Change committed as 213399

Powered by Google App Engine
This is Rietveld 408576698