Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3295)

Unified Diff: chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc

Issue 19532006: Minor cleanup for SystemInfoStorageApiTest. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/systeminfo/storage/test_storage_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc
===================================================================
--- chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc (revision 213035)
+++ chrome/browser/extensions/api/system_info_storage/system_info_storage_apitest.cc (working copy)
@@ -1,10 +1,10 @@
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+
#include "base/command_line.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/timer/timer.h"
#include "chrome/browser/extensions/api/system_info_storage/storage_info_provider.h"
#include "chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.h"
#include "chrome/browser/extensions/extension_apitest.h"
@@ -27,7 +27,7 @@
using extensions::TestStorageUnitInfo;
using extensions::TestStorageInfoProvider;
-struct TestStorageUnitInfo kTestingData[] = {
+const struct TestStorageUnitInfo kTestingData[] = {
{"dcim:device:0004", "transient:0004", "0xbeaf", kStorageTypeUnknown,
4098, 1000, 0},
{"path:device:002", "transient:002", "/home", kStorageTypeFixed,
@@ -36,14 +36,14 @@
10000, 1000, 4097}
};
-struct TestStorageUnitInfo kRemovableStorageData[] = {
+const struct TestStorageUnitInfo kRemovableStorageData[] = {
{"dcim:device:0004", "transient:0004", "/media/usb1",
kStorageTypeRemovable, 4098, 1000, 1}
};
} // namespace
-class SystemInfoStorageApiTest: public ExtensionApiTest {
+class SystemInfoStorageApiTest : public ExtensionApiTest {
public:
SystemInfoStorageApiTest() {}
virtual ~SystemInfoStorageApiTest() {}
@@ -59,8 +59,7 @@
}
void AttachRemovableStorage(const std::string& device_id) {
- size_t len = arraysize(kRemovableStorageData);
- for (size_t i = 0; i < len; ++i) {
+ for (size_t i = 0; i < arraysize(kRemovableStorageData); ++i) {
if (kRemovableStorageData[i].device_id != device_id)
continue;
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/systeminfo/storage/test_storage_api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698