Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index 766e9dde50ec1c8e6f46a3fbd3ea6432ba341fd8..a7070d055de7346ce2f20152e1dde8525681c5d1 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -36,15 +36,23 @@ Polymer({
observer: 'currentRouteChanged_',
},
- // If false the 'basic' page should be shown.
- showAdvancedPage_: {
- type: Boolean,
- value: false
- }
+ /** @private */
+ showAdvancedPage_: Boolean,
+
+ /** @private */
+ showBasicPage_: Boolean,
+
+ /** @private */
+ showAboutPage_: Boolean,
},
- /** @private */
- currentRouteChanged_: function(newRoute, oldRoute) {
+ /**
+ * @param {!SettingsRoute} newRoute
+ * @private
+ */
+ currentRouteChanged_: function(newRoute) {
+ this.showAboutPage_ = newRoute.page == 'about';
this.showAdvancedPage_ = newRoute.page == 'advanced';
+ this.showBasicPage_ = newRoute.page == 'basic';
},
});

Powered by Google App Engine
This is Rietveld 408576698