Chromium Code Reviews| Index: chrome/browser/resources/settings/settings_main/settings_main.js |
| diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js |
| index 766e9dde50ec1c8e6f46a3fbd3ea6432ba341fd8..ab246f9f9c04087888e9526b22ce0cd0832b1da6 100644 |
| --- a/chrome/browser/resources/settings/settings_main/settings_main.js |
| +++ b/chrome/browser/resources/settings/settings_main/settings_main.js |
| @@ -36,15 +36,20 @@ Polymer({ |
| observer: 'currentRouteChanged_', |
| }, |
| - // If false the 'basic' page should be shown. |
| - showAdvancedPage_: { |
| - type: Boolean, |
| - value: false |
| - } |
| + /** @private */ |
| + showAdvancedPage_: Boolean, |
| + |
| + /** @private */ |
| + showBasicPage_: Boolean, |
| + |
| + /** @private */ |
| + showAboutPage_: Boolean, |
| }, |
| /** @private */ |
|
dschuyler
2016/05/05 21:58:20
nit:
@param {SettingsRoute} newRoute blah blah.
dpapad
2016/05/05 22:13:53
Done.
|
| currentRouteChanged_: function(newRoute, oldRoute) { |
|
dschuyler
2016/05/05 21:58:20
Let's remove oldRoute (or add an @param for it,
bu
dpapad
2016/05/05 22:13:53
Done.
|
| + this.showAboutPage_ = newRoute.page == 'about'; |
| this.showAdvancedPage_ = newRoute.page == 'advanced'; |
| + this.showBasicPage_ = newRoute.page == 'basic'; |
| }, |
| }); |