chrome/browser/resources/settings/settings_page/settings_router.js - Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1953093002: MD Settings: Hooking up router to navigate to dummy About page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_main/settings_main.js ('K') | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_router.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_router.js b/chrome/browser/resources/settings/settings_page/settings_router.js

index 8919d5cf17c906a6fad2824d747b45cd03bebedc..9d0d466de4d1e6a7f9e96ed6d6695f11a08c5ad8 100644

--- a/chrome/browser/resources/settings/settings_page/settings_router.js

+++ b/chrome/browser/resources/settings/settings_page/settings_router.js

@@ -96,6 +96,12 @@ Polymer({

subpage: [],

{

+ url: '/about',

dschuyler 2016/05/05 21:58:20 It looks like the legacy url is /help.

dpapad 2016/05/05 22:13:53 Done. BTW, If we want to be 100% consistent with

+ page: 'about',

+ section: '',

+ subpage: [],

+ },

+ {

url: '/advanced',

page: 'advanced',

section: '',