Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1952933002: DevTools: extract the report view to reuse in app manifest and service worker pane. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract the report view to reuse in app manifest and service worker pane. BUG=608997 Committed: https://crrev.com/6c01d8dcde776efc5b0cd101aa80f8175153b02d Cr-Commit-Position: refs/heads/master@{#391766}

Patch Set 1 #

Total comments: 1

Patch Set 2 : tests fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -219 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js View 3 chunks +24 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/appManifestView.css View 1 chunk +0 lines, -81 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/ui/ReportView.js View 1 chunk +176 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 2 chunks +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/ui/reportView.css View 2 chunks +41 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pfeldman
4 years, 7 months ago (2016-05-05 01:56:30 UTC) #2
caseq
lgtm https://codereview.chromium.org/1952933002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js File third_party/WebKit/Source/devtools/front_end/ui/ReportView.js (right): https://codereview.chromium.org/1952933002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js#newcode81 third_party/WebKit/Source/devtools/front_end/ui/ReportView.js:81: /** @type {!Map.<string, !Element>} */ Map<>
4 years, 7 months ago (2016-05-05 01:58:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952933002/1
4 years, 7 months ago (2016-05-05 02:02:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/223905)
4 years, 7 months ago (2016-05-05 03:11:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952933002/20001
4 years, 7 months ago (2016-05-05 04:24:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 05:24:42 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 05:25:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c01d8dcde776efc5b0cd101aa80f8175153b02d
Cr-Commit-Position: refs/heads/master@{#391766}

Powered by Google App Engine
This is Rietveld 408576698